Self-host: suppress apply-patches segfault noise in bootstrap preflight - #9060
Merged
Merged
Conversation
Co-authored-by: Cursor <cursoragent@cursor.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #9040.
Summary
Skip php-llvm-no-closures-array-map.patch (already applied)
Skip php-llvm-context-empty-arrays.patch (already applied)
Skip php-llvm-makearray-empty.patch (already applied)
Skip php-llvm-builder-select.patch (already applied)
Skip php-llvm-value-addincoming.patch (already applied)
Skip php-llvm-llvmabstract-value-addincoming.patch (already applied)
Skip php-llvm-builder-and-or.patch (already applied)
Skip php-llvm-builder-xor.patch (already applied)
Skip php-llvm-pass-registry-interface.patch (already applied)
Skip php-llvm-pass-manager-builder-semicolon.patch (already applied)
Skip php-llvm-pass-manager-builder-typed-prop.patch (already applied)
Skip php-llvm-pass-manager-builder-populate.patch (already applied)
Skip php-llvm-memory-buffer-bitcode.patch (already applied)
Skip php-llvm-vector-get-address-space.patch (already applied)
Skip php-llvm-x86-posix-fallback.patch (already applied)
Applied php-cfg-magic-constants.patch (overlay)
Applied php-cfg-in-operator overlay (In_.php)
Applied php-cfg-exit-two-arg overlay (Exit_.php)
Applied php-cfg-void-cast overlay (Void_.php)
Applied php-cfg-typed-class-const overlay (Language: typed trait constants (PHP 8.3) — const type enforcement when importing traits (Zend/zend_compile.c) #6012)
Skip php-cfg-list-spread.patch (already applied)
Skip php-cfg-incdec-expr.patch (already applied)
Skip php-types-incdec-type.patch (already applied): /app/var/workspaces/3dd76f52-7120-491c-a1c6-8b17b559c210/repo/vendor/ircmaxell/php-types/lib/PHPTypes/TypeReconstructor.php
Skip php-types-incdec-type.patch (already applied): /app/var/workspaces/3dd76f52-7120-491c-a1c6-8b17b559c210/repo/prelinked/bootstrap-vendor/sources/ircmaxell/php-types/lib/PHPTypes/TypeReconstructor.php
skip /app/var/workspaces/3dd76f52-7120-491c-a1c6-8b17b559c210/repo/vendor/ircmaxell/php-cfg/lib/PHPCfg/Parser.php (match overlay current)
Refreshed php-cfg-match.patch (overlay)
Skip php-cfg-assignop-coalesce.patch (already applied)
Skip php-cfg-union-type.patch (already applied)
Skip php-types-union-type.patch (already applied)
Skip php-cfg-readonly-function.patch (already applied)
Skip php-cfg-throw-expr.patch (already applied)
Skip php-types-throw-expr.patch (already applied): /app/var/workspaces/3dd76f52-7120-491c-a1c6-8b17b559c210/repo/vendor/ircmaxell/php-types/lib/PHPTypes/TypeReconstructor.php
Skip php-types-throw-expr.patch (already applied): /app/var/workspaces/3dd76f52-7120-491c-a1c6-8b17b559c210/repo/prelinked/bootstrap-vendor/sources/ircmaxell/php-types/lib/PHPTypes/TypeReconstructor.php
Skip php-cfg-property-readonly.patch (already applied)
Skip php-cfg-dollars-brace.patch (already applied)
Skip php-cfg-mixed-reserved.patch (already applied)
Skip php-cfg-nullsafe.patch (already applied)
Skip php-cfg-nullsafe-parser.patch (already applied)
Skip php-cfg-error-suppress-read.patch (already applied)
Skip php-cfg-error-suppress-simplifier.patch (already applied)
Skip php-cfg-simplifier-call-unpack.patch (already applied)
Skip php-cfg-strict-types.patch (already applied)
Skip php-cfg-trycatch.patch (already applied)
Skip php-cfg-goto-scope.patch (already applied)
Skip php-cfg processAssertions overlay (already applied)
Skip php-cfg-phi-resolver-null.patch (already applied)
Applied php-cfg-magic-constants.patch (overlay)
Skip php-cfg-magic-script-const.patch (already applied)
Skip php-cfg-magic-line.patch (already applied)
Skip php-cfg-switch-cond-property.patch (already applied)
Skip php-cfg-loop-resolver-nested.patch (already applied)
Skip php-cfg-loop-resolver-continue-switch-warning.patch (already applied)
Skip php-cfg-loop-resolver-break-outside-context.patch (already applied)
Skip php-cfg-no-arrow-function.patch (already applied)
Skip php-cfg-no-closure-preg-replace-callback.patch (already applied)
Applied php-cfg-property-type.patch (overlay)
Repair php-cfg-enum.patch (partial Parser.php)
Skip php-cfg-enum-class-method.patch (already applied)
Applied php-cfg-enum-class-const.patch (overlay)
Applied php-cfg-enum-implements.patch (overlay)
Skip php-cfg-enum-class-method.patch (already applied)
Applied php-cfg-enum-class-const.patch (overlay)
Skip php-cfg-enum-abstract.patch (already applied)
Applied php-cfg-typed-class-const overlay (Language: typed trait constants (PHP 8.3) — const type enforcement when importing traits (Zend/zend_compile.c) #6012)
Applied php-cfg-class-const-flags.patch (overlay)
Applied php-cfg-enum-class-const.patch (overlay)
Skip php-cfg-asymmetric-visibility.patch (already applied)
Skip php-cfg-assertion-expr-property.patch (already applied)
Skip php-cfg yield-from overlay (already applied)
Skip php-cfg-incdec-expr.patch (already applied)
Skip php-cfg-yield-keyed.patch (already applied)
skip /app/var/workspaces/3dd76f52-7120-491c-a1c6-8b17b559c210/repo/vendor/ircmaxell/php-cfg/lib/PHPCfg/Parser.php (match overlay current)
Refreshed php-cfg-match.patch (overlay)
Skip php-cfg-halt-compiler.patch (already applied)
Skip php-cfg-compiler-halt-offset overlay (already applied)
Skip php-cfg-assignop-coalesce.patch (already applied)
Skip php-cfg-list-destruct-byref.patch (already applied)
Skip php-cfg-empty-list-assignment.patch (already applied)
Skip php-cfg-list-spread.patch (already applied)
Skip php-cfg-first-class-callable.patch (already applied)
Skip php-cfg-arrow-function.patch (already applied)
Skip php-cfg-anonymous-class.patch (already applied)
Skip php-cfg-new-ctor-parens.patch (optional — stale hunk Language:
newwithout()in class initializers must compile-error (zend_compile.c) #6549; does not block throw-expr Regression: throw expressions — compile aborts (PHPTypes TypeReconstructor missing Expr_Throw, reopen #3802) #6746)Skip php-cfg-anonymous-class-name.patch (already applied)
Repair php-cfg-enum.patch (partial Parser.php)
Skip php-cfg-enum-class-method.patch (already applied)
Applied php-cfg-enum-class-const.patch (overlay)
Applied php-cfg-enum-implements.patch (overlay)
Skip php-cfg-enum-class-method.patch (already applied)
Skip php-cfg-enum-abstract.patch (already applied)
Skip php-cfg-named-args.patch (already applied)
Skip php-cfg-call-time-pass-by-ref.patch (already applied)
Skip php-cfg-spread.patch (already applied)
Skip php-cfg-call-arg-site-clone.patch (already applied)
Skip php-cfg-never-type.patch (already applied)
Skip php-cfg-intersection-type.patch (already applied)
Skip php-cfg-instanceof-union.patch (already applied)
Skip php-cfg-union-type.patch (already applied)
Skip php-cfg-ctor-promotion.patch (already applied)
Skip php-cfg-ctor-promotion-readonly.patch (already applied)
Skip php-cfg-readonly-function.patch (already applied)
Skip php-cfg-property-readonly.patch (already applied)
Skip php-cfg-attribute-groups.patch (already applied)
Skip php-cfg-trait-use.patch (already applied)
Skip php-cfg trait-use overlay (already applied)
Skip php-cfg-throw-expr.patch (already applied)
Skip php-cfg-is-resource-no-assertion.patch (already applied)
Skip php-types-incdec-type.patch (already applied): /app/var/workspaces/3dd76f52-7120-491c-a1c6-8b17b559c210/repo/vendor/ircmaxell/php-types/lib/PHPTypes/TypeReconstructor.php
Skip php-types-incdec-type.patch (already applied): /app/var/workspaces/3dd76f52-7120-491c-a1c6-8b17b559c210/repo/prelinked/bootstrap-vendor/sources/ircmaxell/php-types/lib/PHPTypes/TypeReconstructor.php
Skip php-types-arrow-function.patch (already applied): /app/var/workspaces/3dd76f52-7120-491c-a1c6-8b17b559c210/repo/vendor/ircmaxell/php-types/lib/PHPTypes/TypeReconstructor.php
Skip php-types-arrow-function.patch (already applied): /app/var/workspaces/3dd76f52-7120-491c-a1c6-8b17b559c210/repo/prelinked/bootstrap-vendor/sources/ircmaxell/php-types/lib/PHPTypes/TypeReconstructor.php
Skip php-types-binaryop-pow.patch (already applied)
Skip php-types-binaryop-coalesce.patch (already applied)
Skip php-types-cast-object.patch (already applied)
Skip php-types-cast-unset.patch (already applied)
Skip php-types-binaryop-spaceship.patch (already applied)
Skip php-types-hex2bin-strict.patch (already applied)
Skip php-types-str-bool-fns.patch (already applied)
Skip php-types-str-incdec.patch (already applied)
Skip php-types-str-split-string-array.patch (already applied)
Skip php-types-readfile-int-false.patch (already applied)
Skip php-types-get-meta-tags-array-false.patch (already applied)
Skip php-types-array-combine-array-false.patch (already applied)
Skip php-types-stream-context-array-return.patch (already applied)
Skip php-types-strpbrk-string-false.patch (already applied)
Skip php-types-error-get-last-null.patch (already applied)
Skip php-types-crc32-int.patch (already applied)
Skip php-types-get-declared-functions.patch (already applied)
Skip php-types-gettimeofday-float.patch (already applied)
Skip php-types-round-float.patch (already applied)
Skip php-types-link-bool.patch (already applied)
Skip php-types-gc-enabled-bool.patch (already applied)
Skip php-types-dollars-brace.patch (already applied)
Skip php-types-missing-parent-no-echo.patch (already applied)
Skip php-types-mixed-reserved.patch (already applied)
Skip php-types-nullsafe.patch (already applied)
Skip php-types-static-var.patch (already applied)
Skip php-types-nullable-return.patch (already applied)
Skip php-types-never-type.patch (already applied): /app/var/workspaces/3dd76f52-7120-491c-a1c6-8b17b559c210/repo/vendor/ircmaxell/php-types/lib/PHPTypes/Type.php
Skip php-types-never-type.patch (already applied): /app/var/workspaces/3dd76f52-7120-491c-a1c6-8b17b559c210/repo/prelinked/bootstrap-vendor/sources/ircmaxell/php-types/lib/PHPTypes/Type.php
Skip php-types-cfg-reference.patch (already applied)
Skip php-types-nullable-optype-return.patch (already applied)
Skip php-types-yield-from.patch (already applied)
Skip php-types-fromvalue-null.patch (already applied)
Skip php-types-doc-comment-string.patch (already applied)
Skip php-types-docblock-first-token.patch (already applied)
Applied php-types-array-shape.patch (overlay)
Skip php-types-generics-fallback.patch (already applied)
Skip php-types-generics-list-array.patch (already applied)
Skip php-types-iterable-generic.patch (already applied)
Skip php-types-docblock-trailing-text.patch (already applied)
Applied php-types-callable-return-strip.patch (overlay)
Skip php-types-generic-null-tail.patch (already applied)
Skip php-types-fromdecl-junk-fragments.patch (already applied)
Skip php-types-fromdecl-trailing-comma.patch (already applied)
Skip php-types-remove-type-empty-union.patch (already applied)
Skip php-types-anonymous-class-type.patch (already applied)
Skip php-types-ns-func-call.patch (already applied): /app/var/workspaces/3dd76f52-7120-491c-a1c6-8b17b559c210/repo/vendor/ircmaxell/php-types/lib/PHPTypes/TypeReconstructor.php
Skip php-types-ns-func-call.patch (already applied): /app/var/workspaces/3dd76f52-7120-491c-a1c6-8b17b559c210/repo/prelinked/bootstrap-vendor/sources/ircmaxell/php-types/lib/PHPTypes/TypeReconstructor.php
Skip php-types-arrow-function.patch (already applied): /app/var/workspaces/3dd76f52-7120-491c-a1c6-8b17b559c210/repo/vendor/ircmaxell/php-types/lib/PHPTypes/TypeReconstructor.php
Skip php-types-arrow-function.patch (already applied): /app/var/workspaces/3dd76f52-7120-491c-a1c6-8b17b559c210/repo/prelinked/bootstrap-vendor/sources/ircmaxell/php-types/lib/PHPTypes/TypeReconstructor.php
Skip php-types-closure-unbound-this.patch (already applied)
Skip php-types-magic-script-const.patch (already applied)
Skip php-types-first-class-callable.patch (already applied)
Skip php-types-incdec-type.patch (already applied): /app/var/workspaces/3dd76f52-7120-491c-a1c6-8b17b559c210/repo/vendor/ircmaxell/php-types/lib/PHPTypes/TypeReconstructor.php
Skip php-types-incdec-type.patch (already applied): /app/var/workspaces/3dd76f52-7120-491c-a1c6-8b17b559c210/repo/prelinked/bootstrap-vendor/sources/ircmaxell/php-types/lib/PHPTypes/TypeReconstructor.php
Skip php-types-intersection-type.patch (already applied)
Skip php-types-union-type.patch (already applied)
Skip php-types-throw-expr.patch (already applied): /app/var/workspaces/3dd76f52-7120-491c-a1c6-8b17b559c210/repo/vendor/ircmaxell/php-types/lib/PHPTypes/TypeReconstructor.php
Skip php-types-throw-expr.patch (already applied): /app/var/workspaces/3dd76f52-7120-491c-a1c6-8b17b559c210/repo/prelinked/bootstrap-vendor/sources/ircmaxell/php-types/lib/PHPTypes/TypeReconstructor.php
Skip php-types-compiler-halt-offset overlay (already applied)
Skip pre-plugin-parser-macros.patch (already applied)
Skip pre-plugin-autoload-prepend.patch (already applied) exits non-zero.
Verification
bootstrap-compile-invoke: /compiler/build/bin-compile-aot-inventory -o /compiler/build/selfhost /compiler/test/selfhost/compiler_minimal/main.php (gen-0 compiled)
helloworld_compile_smoke: compile OK -> /compiler/build/selfhost
bootstrap-selfhost-link: OK /compiler/build/selfhost
Made with Cursor