Reject parse_str() one-argument form in all scopes (#4050) - #7873
Merged
Conversation
PHP 8+ requires two arguments; remove the {main}-only import path and VmScope main-script exception so VM and JIT match Zend ArgumentCountError messages.
Co-authored-by: Cursor <cursoragent@cursor.com>
3 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
parse_str()now requires exactly two arguments on VM and JIT, matching PHP 8+ / php-srcext/standard/basic_functions.c{main}one-arg import path (VmScope::requireMainScriptForParseStrOneArg,JitParseStr::parseIntoScopecall site)emitArgumentCountErrorstill segfaults — VM/JIT compliance covers arity)Closes #4050
php-src reference
ext/standard/basic_functions.c—PHP_FUNCTION(parse_str)arity check (PHP 8+)PHP implementation
ext/standard/parse_str.php— VM + JIT loweringext/standard/VmScope.php— deleted main-script one-arg exceptionC runtime shrink
No new C; removed VM scope helper for legacy one-arg import (52 lines net deleted across PHP paths).
Verification
Made with Cursor