Stdlib: parse_str() — reject one-argument form in all scopes (PHP 8+ ext/standard/basic_functions.c)

[PurHur]

Category

stdlib / runtime

Problem

Since PHP 8.0, parse_str() requires two arguments ($encoded_string, &$result). The one-argument form that imported variables into the local symbol table was removed.

This compiler still accepts one argument at main-script scope and imports query vars into the caller frame (ext/standard/parse_str.php + VmScope::requireMainScriptForParseStrOneArg). Zend throws ArgumentCountError everywhere, including top-level scripts.

php-src reference

• php/php-src ext/standard/basic_functions.c — PHP_FUNCTION(parse_str) arity check
• php/php-src ext/standard/basic_functions.stub.php — #[\Deprecated] removal of 1-arg overload

Repro (today)

test/repro-maintainer/parse_str_function_scope.php:

./script/docker-exec.sh -- bash -lc 'php test/repro-maintainer/parse_str_function_scope.php'
# ArgumentCountError on line 11 (script-level one-arg)

./script/docker-exec.sh -- bash -lc 'source script/php-env.sh && php bin/vm.php test/repro-maintainer/parse_str_function_scope.php'
# y:home:y:3  ← script-level one-arg still imports $route/$page (wrong)

Inline check:

./script/docker-exec.sh -- bash -lc 'source script/php-env.sh && php bin/vm.php -r "parse_str(\"x=1\"); echo isset(\$x)?\$x:\"no\";"'
# 1  ← should throw ArgumentCountError

Scope (this repo)

Module	Path
VM	ext/standard/parse_str.php, ext/standard/VmScope.php, ext/standard/VmParseStr.php
JIT	ext/standard/JitParseStr.php — remove main-script one-arg exception
Tests	update test/repro-maintainer/parse_str_function_scope.php; add compliance PHPT

Done when

• One-arg parse_str() throws catchable ArgumentCountError in functions and at main script scope (VM/JIT/AOT)
• Two-arg form unchanged: populates $result array and returns true
• ./script/ci-fast.sh --filter parse_str green

Related

• Epic: Self-host critical path — compiler compiles itself (M3→M5) #1492 · CGI/query parsing uses explicit $params array in modern PHP

[PurHur]

claim: PHP Runtime → PHP — starting this run (#4050: reject parse_str() one-argument form in all scopes).

[PurHur]

Merged via #7873

Verification

• Issue repro: parse_str('x=1') → ArgumentCountError: parse_str() expects exactly 2 arguments, 1 given on VM
• vendor/bin/phpunit --filter parse_str → OK (15 tests, 23 assertions)

PHP-in-PHP: VM/JIT arity enforced in ext/standard/parse_str.php; removed VmScope::requireMainScriptForParseStrOneArg and one-arg import path (~40 lines deleted). No C changes.