[PurHur]

Summary

• version_compare() with an unknown third $operator now throws ValueError (not LogicException / silent false), matching php-src ext/standard/versioning.c.
• VM: VmInfo::evaluateVersionCompareOperator() + applyVersionCompareOperator() shared helper.
• JIT/AOT: compile-time invalid operator lowers via TypeErrorRaise::emitValueError; dynamic operators validated in versionCompareWithOperator().
• Fixes StringVersionCompareJit::emitCompareSpecialForms() branchIf typo (passed icmp value instead of else block) that blocked AOT LLVM lowering.

php-src reference

• ext/standard/versioning.c — php_version_compare() operator validation (zend_argument_value_error)

Verification

# Issue repro — Zend vs VM/JIT
./script/docker-exec.sh -- bash -lc 'source script/php-env.sh
php test/repro-maintainer/version_compare_invalid_operator.php
php bin/vm.php test/repro-maintainer/version_compare_invalid_operator.php
php bin/jit.php test/repro-maintainer/version_compare_invalid_operator.php
'
# All three print:
# version_compare(): Argument #3 ($operator) must be a valid comparison operator

# Compliance + JIT
./script/docker-exec.sh -- bash -lc 'source script/php-env.sh && vendor/bin/phpunit --filter version_compare_invalid_operator'
# VM + JIT: OK (2 tests). AOT fixture: LLVM compile+link reaches run; harness lacks libz (-lz) like other AOT cases.

# AOT lint (compile path)
./script/docker-exec.sh -- bash -lc 'source script/php-env.sh && php bin/compile.php -l test/repro-maintainer/version_compare_invalid_operator.php'
# exit 0

Closes #4319

Made with Cursor