Repository navigation
Stdlib: version_compare() — invalid $operator must throw ValueError (ext/standard/versioning.c parity) #4319
Description
Summary
When the third argument to version_compare() is not a valid comparison operator, Zend throws ValueError. This compiler returns normally (no exception) — silent wrong behavior.
php-src reference
- php/php-src
ext/standard/versioning.c—php_version_compare()operator validation (zend_argument_value_error)
Repro
test/repro-maintainer/version_compare_invalid_operator.php
HARNESS_DOCKER_RUN_OPTS='--memory=8g --cpus=2' ./script/docker-exec.sh -- bash -lc '
source script/php-env.sh
php test/repro-maintainer/version_compare_invalid_operator.php
php bin/vm.php test/repro-maintainer/version_compare_invalid_operator.php
'| Mode | version_compare('1','2','??') |
|---|---|
| Zend | ValueError: … must be a valid comparison operator |
| VM | prints no_ex (no exception) |
Implementation notes
ext/standard/VmInfo.php—applyVersionCompareOperator()throwsLogicExceptiontoday; switch toValueErrorwith Zend message and ensure all invalid operators are rejected (including silent fall-through).- JIT/AOT:
JitInfo::version_compare/ runtime__compiler_version_compareif operator is lowered.
Verification
- Extend
test/compliance/cases/stdlib/version_compare.phptor add dedicated PHPT
Activity
PurHur commentedon Jun 9, 2026
claim: PHP Compiler STD Lib — starting this run
Fix version_compare() invalid operator to throw ValueError (#4319) (#…
PurHur commentedon Jun 9, 2026
Merged via #7840.
Fix: Invalid
version_compare()$operatornow throwsValueErroron VM, JIT, and AOT compile paths (php-srcext/standard/versioning.cparity).Verification:
php bin/vm.php/php bin/jit.php test/repro-maintainer/version_compare_invalid_operator.php→ ValueError messagevendor/bin/phpunit --filter version_compare_invalid_operator→ VM + JIT greenphp bin/compile.php -l test/repro-maintainer/version_compare_invalid_operator.php→ exit 0Also fixed
StringVersionCompareJit::emitCompareSpecialForms()branchIftypo that blocked AOT LLVM lowering for valid-operator calls.