fix(stdlib): str_shuffle() TypeError for non-string operands (#4551)

[PurHur]

Summary

• Wire str_shuffle() through VmString::coerceStringBuiltinArg() (VM) and JitStringBuiltinArg::lower() (JIT/AOT) so non-string argument Php stdlib specs implementation #1 raises TypeError with Zend-like messages, matching php/php-src ext/standard/string.c PHP_FUNCTION(str_shuffle).
• Replaces silent acceptance of [] and LogicException for wrong types.
• Adds compliance PHPT (VM + JIT) and AOT lint fixture.

Closes #4551

php-src reference

• ext/standard/string.c — PHP_FUNCTION(str_shuffle) (Z_PARAM_STR)

Implementation

Path	Role
ext/standard/str_shuffle.php	VM + JIT lowering via shared string-builtin guards
test/compliance/cases/stdlib/str_shuffle_type_error*.phpt	VM/JIT parity
test/fixtures/aot/cases/str_shuffle_type_error.phpt	AOT lint fixture

Verification

./script/docker-exec.sh -- bash -lc 'source script/php-env.sh
php -r "try { str_shuffle([]); } catch (Throwable \$e) { echo get_class(\$e), \": \", \$e->getMessage(), \"\n\"; }"
php bin/vm.php -r "try { str_shuffle([]); } catch (Throwable \$e) { echo get_class(\$e), \": \", \$e->getMessage(), \"\n\"; }"
php bin/compile.php -l -r "str_shuffle([]);"
vendor/bin/phpunit --filter "VMTest::testCases.*str_shuffle"
'

Output:

TypeError: str_shuffle(): Argument #1 ($string) must be of type string, array given
TypeError: str_shuffle(): Argument #1 ($string) must be of type string, array given
OK (4 tests, 4 assertions)

Note: Full AOT link (bin/compile.php -o) and MCJIT execute for type_error PHPTs share pre-existing LLVM verify failures on this harness (same as crc32_type_error / ucfirst_type_error); AOT lint (-l) and VM paths are green.

Made with Cursor