Stdlib: str_shuffle() — TypeError for non-string operands (ext/standard/string.c parity)

[PurHur]

Category

stdlib

Problem

str_shuffle() must accept only string operands. Zend raises TypeError when argument #1 is not a string (e.g. []). This compiler silently accepts non-string values on VM (no exception) and uses LogicException in the builtin guard instead of TypeError.

Affected: VM (ext/standard/str_shuffle.php), JIT (JitStrShuffle via jitString()).

php-src reference

• php/php-src ext/standard/string.c — PHP_FUNCTION(str_shuffle)

Repro (failure today)

./script/docker-exec.sh -- bash -lc 'source script/php-env.sh
php -r "try { str_shuffle([]); echo \"no throw\n\"; } catch (Throwable \$e) { echo get_class(\$e), \": \", \$e->getMessage(), \"\\n\"; }"
php bin/vm.php -r "try { str_shuffle([]); echo \"no throw\n\"; } catch (Throwable \$e) { echo get_class(\$e), \": \", \$e->getMessage(), \"\\n\"; }"
'

Runtime	Behavior
Zend PHP 8.x	TypeError: str_shuffle(): Argument #1 ($string) must be of type string, array given
bin/vm.php	prints no throw (accepts [] without exception)

Scope (this repo)

Module	Path
VM	ext/standard/str_shuffle.php
JIT	ext/standard/JitStrShuffle.php
Tests	test/compliance/cases/stdlib/str_shuffle_type_error.phpt

Done when

• Non-string argument Php stdlib specs implementation #1 raises TypeError with Zend-like message on VM, JIT, and AOT.
• Valid string input behavior unchanged (returns permuted string of same byte length).
• ./script/docker-exec.sh -- bash -lc 'source script/php-env.sh && php bin/vm.php test/compliance/cases/stdlib/str_shuffle_type_error.phpt' exits 0.

[PurHur]

claim: PHP Compiler STD Lib — starting this run

[PurHur]

Merged via #7543.

Fix: str_shuffle() now uses VmString::coerceStringBuiltinArg() (VM) and JitStringBuiltinArg::lower() (JIT/AOT) — array/object argument #1 raises catchable TypeError matching php-src ext/standard/string.c.

Verification (Docker):

• Zend vs VM repro: TypeError: str_shuffle(): Argument #1 ($string) must be of type string, array given
• vendor/bin/phpunit --filter "VMTest::testCases.*str_shuffle" → OK (4 tests)
• php bin/compile.php -l -r "str_shuffle([]);" → exit 0

Full AOT link / MCJIT execute for type_error PHPTs still blocked by pre-existing LLVM verify on this harness (same as crc32_type_error); lowering path is wired via JitStringBuiltinArg.