Repository navigation
JIT: list destruct MCJIT — getMessage catch lowering (#4531) - #7513
Merged
Merged
Conversation
…4531) Catch variables with empty/unresolved userType can call getMessage() during list-destruct TypeError tests. Adds ExceptionGetMessage JIT proxy and routes unknown-object getMessage calls through exception::getmessage. Co-authored-by: Cursor <cursoragent@cursor.com>
Fix duplicate void* extern declarations in StringFsGlobVecJit and StringDirJit that conflicted with LibcExtern; use JitValueBox for Exception::getMessage lowering. Reduces MCJIT module verify errors (glob/scandir select/store) but Runtime->jit() still blocked on remaining runtime-bundle IR (#98). Co-authored-by: Cursor <cursoragent@cursor.com>
Closed
4 tasks
Route ListDestruct*Jit* tests through bin/jit.php child processes (issue #98 pattern) instead of in-process Runtime::jit() module verify. Un-skip JITTest list_destructure_null/string compliance cases now green on bin/jit.php. Co-authored-by: Cursor <cursoragent@cursor.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
ExceptionGetMessageJIT proxy (exception::getmessage) so catch arms can call$e->getMessage()when compiling list-destruct TypeError tests (Language: list/array destructuring from string — must TypeError not null slots (zend_execute.c) #7461 / Language: list destructuring JIT/MCJIT execute — phase 2 of #4308 / #4325 (zend_execute.c) #4531).userTypeininitJitMethodCall()and routes unresolvedgetMessage()through the Exception proxy.StringFsGlobVecJit/StringDirJitlibc signatures withLibcExterni8*params.ListDestruct*Jit*unit probes throughbin/jit.phpsubprocess (CI: Run JIT compliance tests in CI (fix LLVM skip in PHPUnit) #98 pattern); un-skips JITTestlist_destructure_null/list_destructure_stringcompliance cases.test/repro/list_destruct_string_typeerror.phprepro script.Verification
Closes #4531