Fix php-cfg asymmetric visibility overlay anchors (#7468)

[PurHur]

Summary

• Harden apply_php_cfg_asymmetric_visibility_overlay() so promotionGetVisibility inserts after typed or untyped promotionSetVisibility anchors (fixes Param.php promotionSetVisibility anchor missing on partial vendor trees).
• Allow parenthesized public (private(set)) in AsymmetricVisibilityRewriter (php-src RFC form; pairs Language: asymmetric visibility — explicit read+set modifiers wrongly compile-fatal (regression vs #7099, PHP 8.4 RFC) #7308) while keeping bare public private(set) compile-fatal (Language: public private(set) asymmetric visibility — must compile-error (#6589 regression) #7388).
• PHPT harness: compare stdout-only when EXPECT_EXIT + uncaught fatal stderr follows partial output.
• Add maintainer repro test/repro-maintainer/asymmetric_visibility_regression.php.

php-src reference

• Zend/zend_compile.c — asymmetric property visibility (ZEND_ACC_*_SET)
• Zend/zend_language_parser.y — parenthesized (private(set)) modifier grammar

Verification

./script/docker-exec.sh -- bash -lc '
  ./script/apply-patches.sh 2>&1 | grep -i asymmetric || true
  php bin/vm.php test/repro-maintainer/asymmetric_visibility_regression.php
  php vendor/bin/phpunit --filter asymmetric_visibility test/compliance/VMTest.php
  php vendor/bin/phpunit --filter "AsymmetricVisibilityRewriterTest|ApplyPatchesTest::testPhpCfgAsymmetric" test/unit/AsymmetricVisibilityRewriterTest.php test/unit/ApplyPatchesTest.php
'

Output:

Skip php-cfg-asymmetric-visibility.patch (already applied)
hi
Error
OK (21 tests, 23 assertions)   # VM compliance asymmetric_visibility*
OK (17 tests, 27 assertions)   # unit rewriter + overlay probe

Closes #7468

Made with Cursor