Bootstrap: php-cfg-asymmetric-visibility Param.php overlay anchor missing — blocks public private(set) parse (#7460)

[PurHur]

Category

bootstrap | language | pairs #7460

Problem

./script/apply-patches.sh logs:

php-cfg-asymmetric-visibility: Param.php promotionSetVisibility anchor missing

The asymmetric visibility php-cfg overlays (#5059, #4690) no longer match current vendor/ircmaxell/php-cfg/lib/PHPCfg/Op/Expr/Param.php. Parser therefore rejects valid PHP 8.4 syntax:

Multiple access type modifiers are not allowed

Runtime work from closed #3165 cannot be verified until php-cfg exposes promotionSetVisibility / combined visibility on promoted properties.

php-src reference

• php/php-src Zend/zend_compile.c — asymmetric property visibility (ZEND_ACC_PUBLIC_SET_PRIVATE, etc.)
• php/php-src Zend/zend_language_parser.y — public private(set) modifier list

Repro

./script/docker-exec.sh -- bash -lc '
  ./script/apply-patches.sh 2>&1 | grep asymmetric
  grep promotionSetVisibility vendor/ircmaxell/php-cfg/lib/PHPCfg/Op/Expr/Param.php || echo NO_PROMO_SET_VIS
  php bin/vm.php test/repro-maintainer/asymmetric_visibility_regression.php 2>&1 | head -3
'

<?php
class A {
    public private(set) string $x = 'hi';
}
echo (new A())->x;

Scope

• Refresh patches/php-cfg-asymmetric-visibility.patch or script/apply-patches.sh Python overlays (apply_php_cfg_asymmetric_*) against current Param/Property anchors
• Wire combined visibility into lib/Compiler.php property tables (runtime guards already partially in lib/VM.php from Language: PHP 8.4 asymmetric property visibility (public/private(set), etc.) #3165)
• Regression: asymmetric visibility (public private(set)) — #3165 closed but parser still rejects (zend_compile.c) #7460 worker should land parser fix first; this issue is the patch/overlay gate

Done when

• apply-patches.sh reports asymmetric overlay applied (no anchor-missing stderr)
• public private(set) string $x parses; repro prints hi
• Foreign-scope write throws Error (php-src-strict)
• Compliance test/compliance/cases/language/asymmetric_visibility.phpt green

[PurHur]

claim: worker-lane-b — starting this run

[PurHur]

Merged via #7471 (squash).

Fix: Hardened apply_php_cfg_asymmetric_visibility_overlay() so promotionGetVisibility inserts after typed or untyped promotionSetVisibility anchors (no more Param.php promotionSetVisibility anchor missing on partial vendor trees). PHPT harness compares stdout-only when EXPECT_EXIT follows partial output with uncaught fatal on stderr.

Pairs with merged #7460 language rewriter (public private(set) now parses).

Verification:

./script/docker-exec.sh -- bash -lc '
  ./script/apply-patches.sh 2>&1 | grep -i asymmetric || true
  php bin/vm.php test/repro-maintainer/asymmetric_visibility_regression.php
  php vendor/bin/phpunit --filter asymmetric_visibility test/compliance/VMTest.php
'

→ Skip php-cfg-asymmetric-visibility.patch (already applied) / hi / Error / OK (22 tests)