php-in-php: strnatcmp/strnatcasecmp LLVM standalone bodies (#5517) - #6907
Merged
Conversation
Emit strnatcmp/strnatcasecmp LLVM in standalone load type (no phpc_strnatcmp*.c), add JIT compliance + standalone unit test, and AOT fixture. Co-authored-by: Cursor <cursoragent@cursor.com>
This was referenced Jun 6, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
phpc_strnatcmp.c/phpc_strnatcasecmp.cwere already deleted fromlib/AOT/runtime/; this PR emits LLVM bodies for AOT standalone load type (matchingLastErrorRuntimepattern) so linked binaries do not rely on external C symbols..phpt, AOT fixture, and standalone unit test.C runtime shrink
lib/AOT/runtime/phpc_strnatcmp.c,phpc_strnatcasecmp.c— not inLinker.php.strnatcmp/strnatcasecmpas declaration-only stubs.php-src reference
ext/standard/string.c—PHP_FUNCTION(strnatcmp),PHP_FUNCTION(strnatcasecmp)ext/standard/VmString.php,lib/JIT/Builtin/StringNaturalCompareJit.phpVerification
Closes #5517
Made with Cursor