php-in-php: strnatcmp()/strnatcasecmp() — delete phpc_strnatcmp.c + phpc_strnatcasecmp.c (~155 lines)

[PurHur]

Category

php-in-php

Problem

Natural-order string compares are implemented in ext/standard/ for VM (strnatcmp.php, strnatcasecmp.php, VmString), but JIT/AOT still pull in separate C files:

• lib/AOT/runtime/phpc_strnatcmp.c (~72 lines)
• lib/AOT/runtime/phpc_strnatcasecmp.c (~83 lines)

Zend reference is PHP-level string comparison; no need for permanent C tables.

php-src reference

• php/php-src ext/standard/string.c — PHP_FUNCTION(strnatcmp), PHP_FUNCTION(strnatcasecmp)

Scope (this repo)

• Delete both .c files; drop from lib/AOT/Linker.php
• JIT: lower to VmString natural-order helpers (or inline LLVM from PHPlowering)
• Keep VM semantics in ext/standard/strnatcmp.php / strnatcasecmp.php

Repro

<?php var_export(strnatcmp('2', '10'));

./script/docker-exec.sh -- bash -lc 'source script/php-env.sh
cd /compiler
php repro.php    # expect: -1
php bin/vm.php repro.php
'

Both already print -1 today; acceptance is link without C + JIT/AOT parity.

Done when

• C files removed; targeted tests green
• PR notes ~155 lines deleted from lib/AOT/runtime/

[PurHur]

claim: PHP Runtime → PHP — starting this run.

[PurHur]

Unclaiming: phpc_strnatcmp.c / phpc_strnatcasecmp.c already absent from lib/AOT/runtime/ and Linker.php; JIT uses StringNaturalCompareJit + ext/standard. Closing as already done on master — picking #5503 this run instead.

[PurHur]

claim: PHP Runtime → PHP — starting this run (#5517: ensure strnatcmp/strnatcasecmp LLVM bodies for AOT standalone, add standalone test + compliance phpt, close).

[PurHur]

Merged via PR #6907.

C shrink: phpc_strnatcmp.c + phpc_strnatcasecmp.c (~155 lines) already absent from lib/AOT/runtime/ and Linker.php; this PR completes the migration by emitting LLVM bodies for AOT standalone (StringNaturalCompareJit no longer declaration-only).

Verification:

• vendor/bin/phpunit test/compliance/StrnatcmpJITTest.php — OK (1/1)
• VM/JIT repro: strnatcmp('2','10') => -1