Repository navigation
Language: list destructuring with spread — VM parity (#4835) - #4843
Merged
Merged
Conversation
Teach php-cfg parseListAssignment to honor unpack arms, lower TYPE_LIST_SPREAD_ASSIGN for the tail, and slice the list RHS in the VM. Co-authored-by: Cursor <cursoragent@cursor.com>
4 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
parseListAssignmenthonors$item->unpackviaAssign::listSpreadRhs/listSpreadFromIndex(patches/php-cfg-list-spread.patch)TYPE_LIST_SPREAD_ASSIGN; VM copies list tail withHashTable::sliceCopyafterTYPE_LIST_UNPACK_CHECKlist_destructuring_spread.phpt(JIT execute deferred per Language: list destructuring JIT/MCJIT execute — phase 2 of #4308 / #4325 (zend_execute.c) #4531 pattern)Closes #4835
php-src reference
Zend/zend_compile.c— list assignment with unpackZend/zend_execute.c— list unpack runtimeVerification
./script/docker-exec.sh -- bash -lc 'source script/php-env.sh && php bin/vm.php test/repro/list_destructuring_spread_4835.php'Output:
./script/docker-exec.sh -- bash -lc 'source script/php-env.sh && vendor/bin/phpunit --filter list_destructuring_spread'Output:
Made with Cursor