Tooling: php-src sample pass_pct in release-readiness (#36381) - #37495
Merged
Conversation
Wire the sample .phpt corpus into the quick release gate with --json pass_pct, add AOT sample baselines, and keep human logs off the machine JSON channel. Co-authored-by: Cursor <cursoragent@cursor.com>
3 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
release-readiness --jsonnow reportsphp_src_phpt.pass_pctfrom the sample VM--diffcorpus (release criterion surface).php-src-phpt sample --diff(VM); full mode also diffs committed AOT sample baselines.--jsonkeeps human progress on stderr so stdout is pure machine JSON; AOT sample baselines committed (4/4pass,1skip).Test plan
./script/phpunit.sh --filter PhpSrcPhptRunnerTest→ 5/5script/php-src/php-src-phpt.sh --corpus=sample --backend=vm --diff --json→pass_pct=100,diff=okscript/php-src/php-src-phpt.sh --corpus=sample --backend=aot --diff→ DIFF OK./script/aot-smoke.sh→ 9/9 + size gate OK./script/release-readiness.sh --dry-runlistsphp-src-phpt sample --diff (VM, #36381)make north-star5-verify-fastOK on master (spine 8537/8537); CI: php-llvm-structgep-assert.patch fails to apply — blocks north-star5-verify-fast and all bootstrap gates #36143 closed (structgepapply OK)Does not close #36381 — full
Zend/tests+ext/standard/tests+ext/spl/testsbaselines still open.Made with Cursor