Skip to content

CI: php-llvm-structgep-assert.patch fails to apply — blocks north-star5-verify-fast and all bootstrap gates #36143

Description

@PurHur

Parent: #36142

Problem

script/apply-patches.sh fails on patches/php-llvm-structgep-assert.patch:

error: patch failed: vendor/ircmaxell/php-llvm/lib/LLVMAbstract/Builder.php:307

This blocks every Docker gate that runs apply-patches.sh first:

  • make north-star5-verify-fast → exit 1
  • make bootstrap-loop-probe → M0 prerequisite fails
  • ./script/release-readiness.sh --jsonuser_release_ready: no

Root cause

The structGEP/zExt assert guards were partially merged into Builder.php via #16881 / #16933 (#16565), but the patch file still targets the old line context. apply-patches.sh has no skip guard for “already applied”.

Repro

./script/docker-exec.sh -- bash -lc 'script/apply-patches.sh'
# or
make north-star5-verify-fast

Fix direction

One of:

  1. Refresh patches/php-llvm-structgep-assert.patch against current Builder.php, or
  2. Add an idempotency skip in script/apply-patches.sh (grep for the assert block / PHP_COMPILER_LLVM_ASSERT), or
  3. Drop the patch if JIT: shape-aware nested Variable writes + class-const autoload/case fixes (#16565 round 2) #16933 fully subsumes it.

Done when

  • script/apply-patches.sh exits 0 on a clean checkout
  • make north-star5-verify-fast runs past patch application (may still fail later steps — file follow-ups)
  • ./script/release-readiness.sh --json no longer fails on patch step

Verify

./script/docker-exec.sh -- bash -lc 'script/apply-patches.sh && make north-star5-verify-fast'

Activity

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    area:toolingTooling / CI / docsimplementation-readySpec complete: repro, php-src ref, done-when — safe for workers to claimrelease-blockerBlocks tagged user release

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions