Test: scope #36190 undef-var guard assertions to user @fn bodies - #36287
Merged
Conversation
) {main} script CVs intentionally keep module globals for __init__/@main sharing; unit tests must not treat whole-module IR as user-function allocas. Co-authored-by: Cursor <cursoragent@cursor.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
{main}script CVs keep module globals (phpc_scope_var_init_*) so init and @main share one slot; user-function CVs use per-activation entry allocas.UndefinedVariableParameterGuardTestwas asserting whole-module IR has nophpc_scope_var_init, which fails whenever{main}echo materialization exists. Assertions now scope to@fibo_r/@fbodies only.Root cause
#36285 landed the hybrid fix (aot-smoke 9/9 including miniwebapp) but left unit tests written for the all-alloca design.
Verification
Closes #36190
Made with Cursor