JIT: per-frame undef-var flags and skip guards on formals (#36190) - #36285
Merged
Conversation
Replace module-global phpc_scope_var_init_* bits with function-entry i8 allocas so recursive activations do not share assigned state, and omit ZEND_CHECK_UNDEFINED_VAR for parameters that are always defined. Co-authored-by: Cursor <cursoragent@cursor.com>
Co-authored-by: Cursor <cursoragent@cursor.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
phpc_scope_var_init_*assigned flags with per-activation entry allocas for user-function CVs so recursive frames do not share state (matches ZendinitializedSlotsper frame).{main}script CVs — marks/guards can lower in__init__vs@mainand must share one slot without LLVM dominance violations (AOT: print undefined-array-key warnings on stderr (#31991) #36081).ZEND_CHECK_UNDEFINED_VARfor formal parameters (always defined); add unit coverage forfibo_rIR and recursion semantics vs Zend.Test plan
Closes #36190
Made with Cursor