Bootstrap: sync JitHashPbkdf2 into compile spine (#36063) - #36065
Merged
Merged
Conversation
hash_pbkdf2() ValueError guards landed in inventory but the spine require_once was missing, breaking north-star5-verify-fast step 2. Co-authored-by: Cursor <cursoragent@cursor.com>
PurHur
added a commit
that referenced
this pull request
Aug 31, 2026
…6065). (#36068) php-src ext/dom/nodelist.c fixes length/item() on held XPath node-sets: stamp PROP_XPATH_SNAPSHOT, capture query-time XML, and skip live GLOBAL_COUNT decrements and pinned-root item() walks. Co-authored-by: PHP Compiler Ext — DOM & XML <agent@purhur.local> Co-authored-by: Cursor <cursoragent@cursor.com>
PurHur
added a commit
that referenced
this pull request
Sep 1, 2026
…ed trees (#35447). (#36122) #36065 forced compile-time rematerialize on every query() NodeList, which regressed query()->item()->setIdAttribute() — detached nodes SIGSEGV'd. Rematerialize only when query-time snapshot XML differs from the current compile-time tree. Co-authored-by: PHP Compiler Ext — DOM & XML <agent@purhur.local> Co-authored-by: Cursor <cursoragent@cursor.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
require_onceforext/standard/JitHashPbkdf2.phpintest/selfhost/compiler_lib_spine_smoke/main.phpdocs/bootstrap-inventory.mdso spine/inventory counts stay 8041/8041Root cause
hash_pbkdf2()ValueError guards (#12230 / #36059) addedJitHashPbkdf2.phpto inventory but the spine entry was never committed on master, somake north-star5-verify-faststep 2 failed:Test plan
./script/aot-smoke.sh→ 8 passed, 0 failed./script/docker-exec.sh -- bash -lc 'php script/check-selfhost-spine-coverage-sync.php'→ OK (8041/8041)make north-star5-verify-fast→ OK (fast)Closes #36063
Made with Cursor