AOT: hash_pbkdf2() rejects invalid iterations/length with ValueError (#12230) - #36059
Merged
Merged
Conversation
…12230). VM execute() already validated; JIT call() and HashCryptoJitHelper did not. Add runtime IR guards and helper-runtime checks matching ext/hash/hash_pbkdf2.c. Co-authored-by: Cursor <cursoragent@cursor.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
hash_pbkdf2()already threwValueErrorfor$iterations ≤ 0and$length < 0, but AOT compiled throughhash_pbkdf2::call()→__compiler_hash_pbkdf2without checks.JitHashPbkdf2runtime IR guards in the builtin JIT lowering (peer ofJitOpensslRandomPseudoBytes/fread).HashCryptoJitHelper::hashPbkdf2()so thin-standalone helper bridges cannot silently accept bad args.ext/hash/hash_pbkdf2.c—php_hash_pbkdf2().Closes #12230
Test plan
Not run: full compliance suite, differential sweep (no lowering shape change beyond guard blocks).
Made with Cursor