Stdlib: AOT mb_scrub() runtime encoding via NestedJIT (#35161) - #35164
Closed
PurHur wants to merge 1 commit into
Closed
Stdlib: AOT mb_scrub() runtime encoding via NestedJIT (#35161)#35164PurHur wants to merge 1 commit into
PurHur wants to merge 1 commit into
Conversation
Accept non-literal encoding args under AOT like mb_substr_count / mb_convert_case TITLE, using NestedJIT assertEncodingArgv instead of a compile-time LogicException. Co-authored-by: Cursor <cursoragent@cursor.com>
Owner
Author
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
mb_scrub($str, $encoding)with a non-literal encoding no longer fails AOT compile withLogicException.#35155/#35151: NestedJITassertEncodingArgv(Argument Php stdlib specs implementation #2) +encodingPtrlowering; invalid encodings throw catchableValueErrormatching Zend.ext/mbstring/mbstring.c—PHP_FUNCTION(mb_scrub).Test plan
./script/aot-smoke.sh→ 8/8ENC=UTF-8getenv encoding): Zend/VM/AOT all printa?b./script/phpunit.sh --filter MbScrubRuntimeAotTest→ OK (3 tests, 22 assertions)test/repro/mb_scrub_runtime_encoding_aot.phpZend vs AOT byte-identical (incl. bad encoding ValueError)Made with Cursor