Stdlib: AOT mb_scrub() runtime encoding via NestedJIT (#35161) - #35162
Merged
Conversation
Peer of mb_substr_count/mb_strwidth: assertEncodingArgv for Argument #2 so non-literal encodings compile and match Zend under thin AOT. Co-authored-by: Cursor <cursoragent@cursor.com>
This was referenced Aug 26, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
mb_scrub($str, $encoding)refused non-literal encodings under thin AOT (LogicException).assertEncodingArgv(Argument Php stdlib specs implementation #2) +encodingPtrlikemb_substr_count/mb_strwidth(AOT: mb_substr_count() refuses runtime encoding — LogicException (leftover of #4637, ext/mbstring/mbstring.c) #35155 / AOT: mb_strwidth()/mb_strimwidth() refuse runtime encoding — LogicException (leftover of #34264, ext/mbstring/mbstring.c) #34884).ext/mbstring/mbstring.cPHP_FUNCTION(mb_scrub).Test plan
./script/aot-smoke.sh→ 8 passed, 0 failed./script/docker-exec.sh -- bash -lc 'php bin/compile.php -o /tmp/t.bin test/repro/mb_scrub_runtime_encoding_aot.php && /tmp/t.bin'— matches Zend/VM (incl. ValueError on bad encoding)./script/phpunit.sh --filter MbScrubRuntimeAotTest→ OK (3 tests, 22 assertions)Made with Cursor