php-in-php: lazy SuperglobalRefreshRuntime from ensureFullStandaloneBodies (#35137) - #35140
Merged
PurHur merged 1 commit intoAug 26, 2026
Merged
Conversation
…odies (#35137) Defer __superglobals__refresh NestedJIT from ensureFull to compileToFile for every LOAD_TYPE_STANDALONE (thin emitRefresh / full ensureStandaloneBodies), peer of #35133 CliArgv — Trust/#32122 .1 mint class. php-src: main/php_variables.c. Co-authored-by: Cursor <cursoragent@cursor.com>
PurHur
deleted the
agent/issue-35137-superglobal-refresh-ensurefull-lazy
branch
August 26, 2026 14:10
2 of 3 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
SuperglobalRefreshRuntime::ensureStandaloneBodiesfromContext::ensureFullStandaloneBodies(Trust/Release v1.1.0: fix cold-build-check compile_failed on hello world (LLVM Module.php line 180; re-#24302) #32122__superglobals__refresh.1mint class). Peer of CliArgv php-in-php: drop Context ensureFullStandaloneBodies always-on CliArgvRuntime — lazy at compileToFile / CliArgvGlobalInit (ext/standard/basic_functions.c) #35133.compileToFileensures refresh for everyLOAD_TYPE_STANDALONEbefore main emits__superglobals__refresh(thin:ensureUserScriptRefreshEmit; full:ensureStandaloneBodies). Bootstrap-aot fixtures keepensureBootstrapAotStandaloneBodies.main/php_variables.c— CGI/CLI SAPI variable import.Test plan
./script/aot-smoke.sh→ 8 passed, 0 failed./script/phpunit.sh --filter 'ContextFullStandaloneLazy…'(SuperglobalRefresh + peer shrinks) → OK (49 tests, 343 assertions)$_SERVER['REQUEST_METHOD']withREQUEST_METHOD=GET→GET|3Made with Cursor