Repository navigation
Conversation
Thin AOT no longer throws LogicException on runtime haystack or literal encodings-list calls — MbDetectEncodingJitHelper mirrors Zend detect order without VmMbstring. php-src: ext/mbstring/mbstring.c PHP_FUNCTION(mb_detect_encoding). Co-authored-by: Cursor <cursoragent@cursor.com>
Owner
Author
|
Superseded by #34359 already merged on master — duplicate NestedJIT mb_detect_encoding fix. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
mb_detect_encoding()thin AOT threwLogicExceptionon runtime haystack or literal encodings-list + strict; only 1-arg string literals folded.MbDetectEncodingJitHelper+MbDetectEncodingRuntime(peer AOT: mb_scrub() refuses runtime strings — LogicException (leftover of #6050, ext/mbstring/mbstring.c) #34338mb_scrub) — UTF-8/ASCII/ISO-8859-1/8BIT leaf detect withoutVmMbstring.JitMbDetectEncoding::invokefor runtime string + compile-time encodings/strict; spine-sync helper units.php-src:
ext/mbstring/mbstring.c—PHP_FUNCTION(mb_detect_encoding).Test plan
./script/aot-smoke.sh→ 8 passed, 0 failed./script/phpunit.sh --filter MbDetectEncodingRuntimeAotTest→ OK (2 tests, 11 assertions)php script/check-selfhost-spine-coverage-sync.php→ OK (7876/7876)Not run: full differential sweep,
north-star5-verify-fast, compliance suites.Made with Cursor