AOT: mb_detect_encoding() runtime haystack via NestedJIT (#34358) - #34359
Merged
Merged
Conversation
Wire JitMbDetectEncoding::invoke for runtime $string plus compile-time encodings list/strict; MbDetectEncodingJitHelper inlines letter-order walks (NestedJIT === on helper params and int< misfire). Closes #34358. Co-authored-by: Cursor <cursoragent@cursor.com>
4 tasks done
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
JitMbDetectEncoding::invoke()for runtime$stringwith compile-time encodings list /$strict(2–3 arg forms).MbDetectEncodingJitHelper+MbDetectEncodingRuntimeNestedJIT bridge; letter-order logic stays inlined indetectArgv(NestedJIT===on helper params andint<between indices both misfire).MbDetectEncodingRuntimeAotTest; spine requires for helper/runtime link.Closes #34358.
Test plan
./script/phpunit.sh --filter MbDetectEncodingRuntimeAotTest— AOT output matches Zend./script/aot-smoke.sh— 8/8php script/check-selfhost-spine-coverage-sync.php— OKMade with Cursor