Repository navigation
AOT: date_default_timezone_get/set NestedJIT coerce (#33950) - #33953
Merged
PurHur merged 1 commit intoAug 22, 2026
Merged
Conversation
Thin AOT SIGSEGV'd on get and always returned false from set because the ABI bridge skipped JitNestedHelperCoerce and NestedJIT could not use VmDate::$defaultTimezone. Coerce string/bool returns and keep the default zone in the helper TU with durable copy + zoneinfo is_file validation. Co-authored-by: Cursor <cursoragent@cursor.com>
This was referenced Aug 22, 2026
AOT: date('T'/'e'/'O'/'P') after date_default_timezone_set still UTC-bakes (#33950 follow-up)
#33956
Closed
PurHur
added a commit
that referenced
this pull request
Aug 22, 2026
…33958) #33953 fixed get/set but free date('T') still UTC-baked at compile time. Route those tokens through DefaultTimezoneCivilJitHelper sharing the NestedJIT DefaultTimezoneJitHelper static (peer #33943 / #33950). Co-authored-by: PurHur <PurHur@users.noreply.github.com> Co-authored-by: Cursor <cursoragent@cursor.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
date_default_timezone_get()and always-falsedate_default_timezone_set()(Closes #33950).DefaultTimezoneRuntimenow usesJitNestedHelperCoerce::callHelper+extractStringPtrFromHelperResult/extractBoolFromHelperResult(peers: IniRuntime / php-in-php: NestedJIT helper return ABI for double + __hashtable__* + string|false value-box (unblocks thin AOT always-helper) #20664 / bootstrap-aot-link: VALUE-box concat + ordered float compare lowering #8555).DefaultTimezoneJitHelperowns the default-TZ static (NestedJIT cannot safely readVmDate::$defaultTimezone), validates via zoneinfois_file, and durable-copies ids into the static.php-src:
ext/date/php_date.c—PHP_FUNCTION(date_default_timezone_get/set).Follow-up: free
date('T')after runtimedate_default_timezone_setstill uses the #33943 UTC bake.Test plan
./script/aot-smoke.sh→ 8/8./script/phpunit.sh --filter 'Issue33950DefaultTimezoneAotTest|DefaultTimezoneRuntimeShrinkTest'→ OK (6 tests)#33943date tz-token repro still matches Zend under UTC defaultMade with Cursor