Repository navigation
AOT: filter_input IF_G snapshot vs live $_GET (#33946) - #33949
Merged
Merged
Conversation
Standalone refresh deep-copies GET/POST/COOKIE into if_* so filter_input and filter_has_var match php-src request tables (re-#19640); MCJIT falls back to live sg_* while if_* is unset. Co-authored-by: Cursor <cursoragent@cursor.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
filter_input()/filter_has_var()read livesg_GETafter Stdlib: filter_input() request-input snapshot vs live $_GET (#19640) #19650 left JIT/AOT on the mutable tables — CLI showed42where Zend/VM returnNULL.__superglobals__refreshnow deep-copies GET/POST/COOKIE intoif_*IF_G globals; filter lowering prefers those snapshots (MCJIT falls back to livesg_*whileif_*is unset).php-src:
ext/filter/filter.c—php_filter_get_input/IF_G(get_array)Closes #33946
Test plan
./script/aot-smoke.sh→ 8 passed, 0 failedNULL/NULL/false(matches Zend/VM)QUERY_STRING=x=42AOT →42/42/'99'(matches VM)./script/phpunit.sh --filter 'filter_input_request_snapshot|filter_input_cgi_snapshot_immutable' test/aot/AotTest.php→ OK (2 tests)Verification transcript
Made with Cursor