Repository navigation
Stdlib: filter_input() request-input snapshot vs live $_GET (#19640) - #19650
Merged
Merged
Conversation
Capture IF_G-style copies when CGI populates \$_GET/\$_POST/\$_COOKIE so filter_input/filter_has_var/filter_input_array ignore later superglobal writes. CLI with empty request tables returns NULL like Zend. Co-authored-by: Cursor <cursoragent@cursor.com>
This was referenced Jul 16, 2026
This was referenced Aug 22, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
$_GET/$_POST/$_COOKIE(php-src IF_G semantics).filter_input()/filter_has_var()/filter_input_array()read the snapshot, not live mutable superglobals — CLI empty request →NULL; CGI query still works after$_GET[...] =writes.sg_*; VM is php-src-strict).php-src:
ext/filter/filter.c—php_filter_get_inputTest plan
NULL/NULL/falseon VMQUERY_STRING=x=42→42then still42after$_GET['x']='99'filter_batch_apiVerification
Closes #19640
Made with Cursor