php-in-php: drop Type always-on __compiler_assert_fail_string ABI shell (#33241) - #33243
Merged
Merged
Conversation
4 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Builtin\Typealways-on empty__compiler_assert_fail_stringdecl that can mintassert_fail_string.1under ABI drift (Fix: AOT link fails for EVERY binary — duplicate memset declaration #31894 / Release v1.1.0: fix cold-build-check compile_failed on hello world (LLVM Module.php line 180; re-#24302) #32122 class).AssertFail(getNamedFunctionfirst, thenaddFunctionif absent; thin/standalone declare-only onensureLinked, bodies viaensureStandaloneBodies/ full load).JitAssert/Type::initializeensureLinkedbefore lookup.ext/standard/assert.c. No newruntime/*.c. Next leftover sentinel:__compiler_assert_options.Test plan
./script/phpunit.sh --filter 'TypeDeadAssertFailStringAbiRuntimeShrinkTest|TypeDeadAssertFailAbiRuntimeShrinkTest'→ OK (8 tests, 38 assertions)./script/aot-smoke.sh→ 8 passed, 0 failedassert(false, "custom")withassert.exception=0: Zend/VM →PHP Warning: assert(): custom failed+after; thin AOT compiles and runsafterMade with Cursor