Skip to content

php-in-php: drop Type always-on __compiler_assert_fail_string ABI shell (#33241) - #33243

Merged
PurHur merged 1 commit into
masterfrom
agent/issue-33241-assert-fail-string-abi
Aug 21, 2026
Merged

PurHur merged 1 commit into
masterfrom
agent/issue-33241-assert-fail-string-abi

Conversation

@PurHur

@PurHur PurHur commented Aug 21, 2026

Copy link
Copy Markdown
Owner

Summary

Test plan

  • ./script/phpunit.sh --filter 'TypeDeadAssertFailStringAbiRuntimeShrinkTest|TypeDeadAssertFailAbiRuntimeShrinkTest' → OK (8 tests, 38 assertions)
  • ./script/aot-smoke.sh → 8 passed, 0 failed
  • assert(false, "custom") with assert.exception=0: Zend/VM → PHP Warning: assert(): custom failed + after; thin AOT compiles and runs after

Made with Cursor

…ll (#33241)

Leftover empty Type decls vs AssertFail can mint assert_fail_string.1 (#31894 / #32122). Owner declares module-locally; ensureLinked on full load and JitAssert call sites.

Co-authored-by: Cursor <cursoragent@cursor.com>
@PurHur
PurHur merged commit 2eea60d into master Aug 21, 2026
1 check failed
@PurHur
PurHur deleted the agent/issue-33241-assert-fail-string-abi branch August 21, 2026 04:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

php-in-php: drop leftover Type always-on __compiler_assert_fail_string ABI shell (ext/standard/assert.c)

1 participant