php-in-php: drop leftover Type always-on __compiler_assert_fail_string ABI shell (ext/standard/assert.c)

[PurHur]

Category

php-in-php · Trust / #32122-class leftover Type always-on ABI shell

Problem

After #33237 dropped __compiler_assert_fail, Builtin\Type still always-on addFunction/registerFunction for __compiler_assert_fail_string. Leftover empty Type decls vs Runtime ABI drift mint assert_fail_string.1 (#31894 / #32122). Sentinel after #33237.

Path	Owner today
__compiler_assert_fail	AssertFail module-local (#33237)
__compiler_assert_fail_string	still Type always-on

php-src reference

• php/php-src ext/standard/assert.c — assert() failure / string description path

PHP implementation target

• lib/JIT/Builtin/AssertFail.php — declare __compiler_assert_fail_string module-locally (getNamedFunction first, then addFunction if absent)
• lib/JIT/Builtin/Type.php — remove always-on empty decl; keep AssertFail::ensureLinked
• ext/standard/JitAssert.php — ensureLinked before lookup (already)
• No new runtime/*.c

Repro / gate

./script/phpunit.sh --filter TypeDeadAssertFailStringAbiRuntimeShrinkTest
./script/aot-smoke.sh

Done when

• Type.php has no always-on __compiler_assert_fail_string add/register
• AssertFail owns module-local decl; unit shrink test green
• aot-smoke 8/8
• No new runtime/*.c

[PurHur]

claim: implementer-worker-lane-a — starting this run (lane overflow: #32122 / #31968 children closed; open AOT IR queue empty; Trust/#32122-class leftover Type always-on __compiler_assert_fail_string after #33237 sentinel; #33234 trigger_error claimed <48h)

[PurHur]

merged: #33243 (2eea60dac9)

Fix: AssertFail now declares __compiler_assert_fail_string module-locally (getNamedFunction first); Type always-on shell removed so leftover empty decls cannot mint assert_fail_string.1 (#31894 / #32122).

Verification

• ./script/phpunit.sh --filter 'TypeDeadAssertFailStringAbiRuntimeShrinkTest|TypeDeadAssertFailAbiRuntimeShrinkTest' → OK (8 tests, 38 assertions)
• ./script/aot-smoke.sh → 8 passed, 0 failed
• assert(false, "custom") Zend/VM warning + after; thin AOT runs after

Next leftover sentinel: __compiler_assert_options.