Repository navigation
php-in-php: drop leftover Type always-on openssl_pbkdf2 ABI shell (#32869) - #32873
Merged
Merged
Conversation
This was referenced Aug 20, 2026
Closed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Builtin\Typealways-on empty decl for__compiler_openssl_pbkdf2so leftover Type shells cannot mintopenssl_pbkdf2.1(Fix: AOT link fails for EVERY binary — duplicate memset declaration #31894 / Release v1.1.0: fix cold-build-check compile_failed on hello world (LLVM Module.php line 180; re-#24302) #32122).OpensslPbkdf2Runtimeowns the ABI module-locally (getNamedFunctionfirst +declareAbi);Type::initializestillensureLinkeds it.Type.php; no newruntime/*.c. Peer of php-in-php: drop leftover Type always-on openssl_sign/verify ABI shells (ext/openssl/openssl.c) #32866 / php-in-php: drop leftover Type always-on openssl_digest ABI shell (ext/openssl/openssl.c) #32868. Closes php-in-php: drop leftover Type always-on openssl_pbkdf2 ABI shell (ext/openssl/openssl.c) #32869.php-src:
ext/openssl/openssl.c(PHP_FUNCTION(openssl_pbkdf2)/PKCS5_PBKDF2_HMAC)Test plan
./script/aot-smoke.sh→ 8 passed, 0 failed (pre-rebase @ f1ab533; post-rebase unit gate below)./script/phpunit.sh --filter 'TypeDeadOpensslPbkdf2AbiRuntimeShrinkTest|TypeDeadOpensslDigestAbiRuntimeShrinkTest|OpensslPbkdf2JitTest'→ OK (9 tests, 44 assertions) after rebase onto php-in-php: drop leftover Type always-on openssl_digest ABI shell (ext/openssl/openssl.c) #32868Made with Cursor