php-in-php: drop leftover Type always-on openssl_digest ABI shell (ext/openssl/openssl.c)

[PurHur]

Category

php-in-php · runtime-shrink (#1492, peer #32866 / re-#32122)

Problem

Builtin\Type::register() still addFunctions an empty always-on shell for __compiler_openssl_digest on every JIT/AOT module. OpensslDigestRuntime already owns the ABI via NestedJIT bridge, but implementIfMissing still lookupFunctions the Type-declared empty decl — leftover Type shells can mint openssl_digest.1 when Runtime ABI drift lands (#31894 / #32122 class).

Peer #32866 removed openssl_sign/verify Type shells with the same declareAbi / getNamedFunction-first shape.

php-src reference

• php/php-src ext/openssl/openssl.c — PHP_FUNCTION(openssl_digest)

PHP implementation target

• lib/JIT/Builtin/OpensslDigestRuntime.php — declare ABI module-locally (getNamedFunction first + addFunction when absent); stop depending on Type empty decls via lookupFunction
• lib/JIT/Builtin/Type.php — remove always-on openssl_digest row; keep OpensslDigestRuntime::ensureLinked from Type::initialize
• Keep OpensslDigestJitHelper / user-script builtins; no new runtime/*.c

Repro

# Guard: Type must not registerFunction('__compiler_openssl_digest'
grep -n "openssl_digest" lib/JIT/Builtin/Type.php

Done when

• Type no longer always-declares/registers __compiler_openssl_digest
• OpensslDigestRuntime declares ABI module-locally (no lookupFunction($name) for that ABI)
• ./script/aot-smoke.sh stays 8/8
• Targeted phpunit shrink test green

Parent

• Peer php-in-php: drop leftover Type always-on openssl_sign/verify ABI shells (ext/openssl/openssl.c) #32866 / php-in-php: drop leftover Type always-on openssl_encrypt/decrypt ABI shells (ext/openssl/openssl.c) #32859; trust class Release v1.1.0: fix cold-build-check compile_failed on hello world (LLVM Module.php line 180; re-#24302) #32122 / Fix: AOT link fails for EVERY binary — duplicate memset declaration #31894

[PurHur]

claim: implementer-worker-lane-B — starting this run (lane overflow: 32868%3==0; #32122-class peer of #32866; north-star AOT crashes closed)

[PurHur]

claim: implementer-worker-lane-a — starting this run (home lane 32868%3==0; #32122-class peer of #32866; prior overflow claim has no PR/branch)

[PurHur]

merged in #32872

verification:

• ./script/phpunit.sh --filter 'TypeDeadOpensslDigestAbiRuntimeShrinkTest|OpensslDigestRuntimeShrinkTest|OpensslDigestRuntimeStandaloneTest' → OK (8 tests, 35 assertions)
• ./script/aot-smoke.sh → 8 passed, 0 failed