php-in-php: drop Type always-on time_nanosleep/time_sleep_until ABI shells (#32721) - #32722
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
__compiler_time_nanosleep/__compiler_time_sleep_untilshells fromBuiltin\Type::register()—TimeSleepRuntimealready owns these viaJitVmHelperLink::ensureBridge(getNamedFunction first).addFunctionvs Runtime ABI drift that mintstime_nanosleep.1and breaks cold-build / module verify (Fix: AOT link fails for EVERY binary — duplicate memset declaration #31894 / Release v1.1.0: fix cold-build-check compile_failed on hello world (LLVM Module.php line 180; re-#24302) #32122 class; peer php-in-php: drop leftover Type always-on hrtime ABI shells (ext/standard/hrtime.c) #32712 hrtime shrink).time_nanosleep()/time_sleep_until()unchanged (JitSleep→SleepJitHelper→VmSleepPure).runtime/*.c.php-src:
ext/standard/basic_functions.c—PHP_FUNCTION(time_nanosleep),time_sleep_untilCloses #32721
Test plan
./script/phpunit.sh --filter 'TypeDeadTimeSleepAbiRuntimeShrinkTest|TimeSleepRuntimeStandaloneTest'→ OK (7 tests, 37 assertions)./script/aot-smoke.sh→aot-smoke: 8 passed, 0 failedMade with Cursor