Skip to content

php-in-php: drop leftover Type always-on time_nanosleep/time_sleep_until ABI shells (ext/standard/basic_functions.c) #32721

Description

@PurHur

Category

php-in-php · runtime-shrink (#1492, peer #32712 / re-#32122)

Problem

Builtin\Type::register() still addFunctions empty always-on shells for __compiler_time_nanosleep and __compiler_time_sleep_until on every JIT/AOT module. Runtime owner already declares module-locally via JitVmHelperLink::ensureBridge (getNamedFunction first):

  • TimeSleepRuntime / SleepJitHelper — time_nanosleep / time_sleep_until

Leftover Type addFunction vs Runtime ABI drift mints time_nanosleep.1 (#31894 / #32122 class).

php-src reference

  • ext/standard/basic_functions.c — PHP_FUNCTION(time_nanosleep), time_sleep_until

Done when

  • Type.php does not always-declare the two ABI names
  • TimeSleepRuntime still owns the ABI
  • aot-smoke.sh stays 8/8
  • No new runtime/*.c

Activity

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    implementation-readySpec complete: repro, php-src ref, done-when — safe for workers to claim

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions