JIT: ldap_compare() via LdapResultJitHelper bridge (#32121) - #32127
Merged
Merged
Conversation
Route compiled ldap_compare through PHP helper + JitVmHelperLink in LdapRuntime instead of the LogicException stub; semantics stay in ext/ldap/VmLdapCore with no new C runtime surface. Co-authored-by: Cursor <cursoragent@cursor.com>
3 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
LdapResultJitHelper::compareArgv+JitLdapResult::invokeCompareso compiledldap_compare()delegates to existingVmLdapCore::compare()semantics (php-srcext/ldap/ldap.c).__compiler_ldap_comparebridge inLdapRuntime.phpviaJitVmHelperLink::ensureBridge— no newruntime/*.clogic.LogicExceptionstub inldap_compare::call().C runtime shrink
No C added. Behavior lives entirely in
ext/ldap/+lib/JIT/Builtin/LdapRuntime.php.Test plan
Not run: full compliance shard, bootstrap-selfhost-link, differential-sweep (no lowering/CFG change beyond ldap_compare bridge).
Closes #32121
Made with Cursor