Stdlib: ldap_compare() JIT lowering missing — VM path only (ext/ldap/ldap.c)

[PurHur]

Category

stdlib · php-src-strict · ext/ldap · JIT/AOT lowering

Problem

ldap_compare() works on the VM via VmLdapCore::compare(), but compiled JIT/AOT calls still throw LogicException from call() in ext/ldap/ldap_result_builtins.php. This leaves compiled PHP behind the existing PHP-side runtime path even though the semantics already live in ext/ldap/ and VmLdapNative.

Repro	Zend 8.2+	VM	JIT/AOT
ldap_compare($ldap, "cn=x", "cn", "x")	callable	callable	LogicException today

php-src reference

• php/php-src ext/ldap/ldap.c — PHP_FUNCTION(ldap_compare)

PHP implementation target

• ext/ldap/ldap_result_builtins.php — replace the JIT stub in ldap_compare::call()
• ext/ldap/JitLdapResult.php + ext/ldap/LdapResultJitHelper.php — lower handle + string args through PHP helper code
• lib/JIT/Builtin/LdapRuntime.php — register the bridge; keep behavior in PHP, no new runtime/*.c logic

Repro

./script/docker-exec.sh -- bash -lc 'source script/php-env.sh && php -d display_errors=1 ./phpc run test/repro/issue_ldap_compare_jit.php'

Done when

• JIT/AOT accept LDAP\Connection, string $dn, string $attribute, string $value with php-src-strict type errors
• Return shape matches VM/php-src subset already implemented: true / false / -1 plus warning/errno side effects
• Targeted repro + unit coverage added

[PurHur]

claim: PHP Runtime → PHP — starting this run

[PurHur]

claim: PHP Runtime → PHP — starting this run (continuing ldap_compare JIT bridge in LdapRuntime + LdapResultJitHelper).

[PurHur]

Merged via #32127.

Verification (Docker):

• ./script/phpunit.sh --filter 'LdapCompareJitHelperTest|LdapRuntimeShrinkTest' → OK (4 tests, 37 assertions)
• PHP_COMPILER_ENABLE_LDAP=1 php bin/jit.php test/repro/issue_ldap_compare_jit.php → fn=1, result=-1, ok
• PHP_COMPILER_ENABLE_LDAP=1 php bin/jit.php test/compliance/cases/ext/ldap_compare_parse.phpt → matches --EXPECT (compare TypeError + -1 path)

PHP-in-PHP: ldap_compare JIT routes through LdapResultJitHelper + __compiler_ldap_compare in LdapRuntime.php; no C runtime added.