Skip to content

Stdlib: GlobIterator empty pattern ValueError cites $pattern (#31529) - #31538

Merged
PurHur merged 1 commit into
masterfrom
fix/31529-globiterator-empty-pattern
Aug 16, 2026
Merged

PurHur merged 1 commit into
masterfrom
fix/31529-globiterator-empty-pattern

Conversation

@PurHur

@PurHur PurHur commented Aug 16, 2026

Copy link
Copy Markdown
Owner

Summary

Closes #31529

Test plan

  • ./script/docker-exec.sh -- bash -lc 'php bin/vm.php test/repro/maintainer_gap_globiterator_empty_pattern.php' → Zend-identical ValueError
  • Null soft-DEP cites $pattern then same ValueError
  • vendor/bin/phpunit --filter Issue31529GlobIteratorEmptyPatternTest

php-src ref: ext/spl/spl_directory.c / spl_directory.stub.phpstring $pattern. PHP impl: ext/spl/GlobIteratorBuiltin.php.

Made with Cursor

Align with DirectoryIterator/FilesystemIterator empty-path wording from
php-src spl_directory.stub.php (residual after #31512/#31525).

Co-authored-by: Cursor <cursoragent@cursor.com>
@PurHur
PurHur merged commit 097e2fe into master Aug 16, 2026
1 check failed
@PurHur
PurHur deleted the fix/31529-globiterator-empty-pattern branch August 16, 2026 19:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Regression: GlobIterator empty pattern ValueError generic Path — Zend Argument #1 ($pattern) (ext/spl/spl_directory.c)

1 participant