Stdlib: DirectoryIterator family empty path cites $directory (#31512)

[PurHur]

Summary

• Closes Regression: DirectoryIterator family null path ValueError generic Path — Zend Argument #1 ($directory) (ext/spl/spl_directory.c) #31512: DirectoryIterator / FilesystemIterator / RecursiveDirectoryIterator empty/null path now throw Zend-shaped ValueError citing Argument Php stdlib specs implementation #1 ($directory) cannot be empty, and null soft-DEP names $directory (not $filename / generic Path cannot be empty).
• PHP-only in ext/spl/* via VmStreamPath::coerceNonEmptyPathArg + VmString::emptyStringArgValueErrorMessageCannot (php-src ext/spl/spl_directory.c / .stub.php).
• Focused VM PHPT + repro under test/repro/maintainer_gap_spl_dir_null_path_message.php.

Test plan

• ./script/docker-exec.sh -- bash -lc 'php bin/vm.php test/repro/maintainer_gap_spl_dir_null_path_message.php'
• ./script/phpunit.sh --filter DirectoryIteratorNullPath31512VMTest
• ./script/phpunit.sh --filter DirectoryIteratorMissing31506VMTest (sibling Regression: DirectoryIterator/FilesystemIterator/RecursiveDirectoryIterator missing path RuntimeException — Zend UnexpectedValueException (ext/spl/spl_directory.c) #31506 still green)

Verification transcript

$ ./script/docker-exec.sh -- bash -lc 'php bin/vm.php test/repro/maintainer_gap_spl_dir_null_path_message.php'
== DirectoryIterator ==
DEP:DirectoryIterator::__construct(): Passing null to parameter #1 ($directory) of type string is deprecated
ValueError: DirectoryIterator::__construct(): Argument #1 ($directory) cannot be empty
ValueError: DirectoryIterator::__construct(): Argument #1 ($directory) cannot be empty
== FilesystemIterator ==
DEP:FilesystemIterator::__construct(): Passing null to parameter #1 ($directory) of type string is deprecated
ValueError: FilesystemIterator::__construct(): Argument #1 ($directory) cannot be empty
ValueError: FilesystemIterator::__construct(): Argument #1 ($directory) cannot be empty
== RecursiveDirectoryIterator ==
DEP:RecursiveDirectoryIterator::__construct(): Passing null to parameter #1 ($directory) of type string is deprecated
ValueError: RecursiveDirectoryIterator::__construct(): Argument #1 ($directory) cannot be empty
ValueError: RecursiveDirectoryIterator::__construct(): Argument #1 ($directory) cannot be empty

$ ./script/phpunit.sh --filter DirectoryIteratorNullPath31512VMTest
OK (1 test, 1 assertion)

Made with Cursor