Repository navigation
Language: Closure::fromCallable([, method]) keeps object receiver (#27137, #27143) - #27161
Merged
Merged
Conversation
This was referenced Aug 3, 2026
PurHur
added a commit
that referenced
this pull request
Aug 3, 2026
…27168) * Trust: refresh gen-0 argv driver fingerprint after #27160/#27161 (#27162) Pillar 1: north-star5-verify-fast failed on lowering_source_fingerprint mismatch after tanh NestedJIT + Closure::fromCallable. Honest argv rebuild (functional smoke OK) stamps fingerprint d142f929… (verified-fresh). Co-authored-by: Cursor <cursoragent@cursor.com> * Trust: re-stamp gen-0 argv fingerprint after #27166 sinh (#27162) Master landed sinh NestedJIT (#27166) during the prior refresh race; honest argv rebuild stamps fingerprint 1742933d… (verified-fresh). Co-authored-by: Cursor <cursoragent@cursor.com> * Trust: re-stamp gen-0 argv after merge race (#27162) Co-authored-by: Cursor <cursoragent@cursor.com> --------- Co-authored-by: PurHur <PurHur@users.noreply.github.com> Co-authored-by: Cursor <cursoragent@cursor.com>
5 tasks
PurHur
added a commit
that referenced
this pull request
Aug 3, 2026
#27137, #27143) (#27161) Lower object-array fromCallable to TYPE_FROM_CALLABLE like bound-method FCC so `$this` is not folded to class name "this", and walk parent proxies for inherited instance methods under AOT. Co-authored-by: PurHur <PurHur@users.noreply.github.com> Co-authored-by: Cursor <cursoragent@cursor.com>
PurHur
added a commit
that referenced
this pull request
Aug 3, 2026
…27168) * Trust: refresh gen-0 argv driver fingerprint after #27160/#27161 (#27162) Pillar 1: north-star5-verify-fast failed on lowering_source_fingerprint mismatch after tanh NestedJIT + Closure::fromCallable. Honest argv rebuild (functional smoke OK) stamps fingerprint d142f929… (verified-fresh). Co-authored-by: Cursor <cursoragent@cursor.com> * Trust: re-stamp gen-0 argv fingerprint after #27166 sinh (#27162) Master landed sinh NestedJIT (#27166) during the prior refresh race; honest argv rebuild stamps fingerprint 1742933d… (verified-fresh). Co-authored-by: Cursor <cursoragent@cursor.com> * Trust: re-stamp gen-0 argv after merge race (#27162) Co-authored-by: Cursor <cursoragent@cursor.com> --------- Co-authored-by: PurHur <PurHur@users.noreply.github.com> Co-authored-by: Cursor <cursoragent@cursor.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Closure::fromCallable([$obj, 'method'])toTYPE_FROM_CALLABLE(same shape as bound-method FCC) so$thisis not folded to the class name"this"(Regression: Closure::fromCallable([$this, private]) — Class 'this' not found (re-#23688, Zend/zend_closures.c) #27137 private, Regression: Closure::fromCallable([$this, protected]) — Class 'this' not found (re-#27137, Zend/zend_closures.c) #27143 protected).VmFromCallable::resolveInstanceProxyNameso AOT resolves inherited instance methods (Bcalling protectedA::f)..phptguards.Closes #27137
Closes #27143
Test plan
test/repro/maintainer_gap_fromcallable_private.php→this_form=7test/repro/maintainer_gap_fromcallable_protected.php→this_form=A#27138static-scope TypeError still green on VMVerification transcript
php-src:
Zend/zend_closures.c— object+method callable; PHP impl inlib/Compiler.php+lib/VM/VmFromCallable.php.Made with Cursor