Repository navigation
Stdlib: fix AOT hex2bin module verify + NestedJIT empty return (#27008) - #27043
Merged
Merged
Conversation
Bridge used i8 for __value__writeBool (needs i32) and a VmString/static lastString helper that NestedJIT stubbed under AOT. Use a self-contained string|false helper and map false via writeBool(i32). Co-authored-by: Cursor <cursoragent@cursor.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
hex2bin()LLVM module verify failure (__value__writeBoolcalled withi8instead ofi32) and empty/false returns from NestedJIT-stubbedVmString+ staticlastString.Hex2binJitHelperas NestedJIT-self-containedstring|false(peer Bin2hex php-in-php: delete JitBin2hexKernel — always JitVmHelperLink + Bin2hexJitHelper PHP (#1492) #20452 / Base64Decode Regression: AOT base64_decode segfaults after build — encode OK (ext/standard/base64.c) #26890) and maps false viawriteBool(i32).Hex2binRuntimeShrinkTestguards.php-src:
ext/standard/string.c—PHP_FUNCTION(hex2bin)PHP:
ext/standard/Hex2binJitHelper.php,lib/JIT/Builtin/StringHex2bin.php,ext/standard/hex2bin.phpCloses #27008
Test plan
php script/bootstrap-inventory.php --check→OK 6819/6819hex2bin("61"."62")→abvendor/bin/phpunit --filter Hex2binRuntimeShrinkTest→ OK (3 tests)AotTest --filter hex2bin(data set"hex2bin") → OKci-local/north-star5-verify --strict(stdlib builtin only; release-readiness already red on master for helper-prelink stale + north-star5-fast)Made with Cursor