Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
15 changes: 13 additions & 2 deletions ext/curl/CurlFileSerializeDeny.php
Original file line number Diff line number Diff line change
Expand Up @@ -5,10 +5,21 @@
namespace PHPCompiler\ext\curl;

/**
* php-src ext/curl/curl_file.stub.php — @not-serializable on CURLFile (#23064).
* php-src @not-serializable curl objects:
* - CURLFile — ext/curl/curl_file.stub.php (#23064)
* - CurlHandle / CurlMultiHandle / CurlShareHandle — ext/curl/curl.stub.php (#23074)
*/
final class CurlFileSerializeDeny
{
/** @var list<string> */
private const DENIED_LC = [
CurlFileBuiltin::CLASS_LC,
VmCurlEasy::CLASS_LC,
VmCurlMulti::CLASS_LC,
VmCurlShare::CLASS_LC,
VmCurlShare::PERSISTENT_CLASS_LC,
];

public static function rejectSerialization(string $className): void
{
if (self::isDenied($className)) {
Expand All @@ -25,7 +36,7 @@ public static function rejectUnserialization(string $className): void

private static function isDenied(string $className): bool
{
return CurlFileBuiltin::CLASS_LC === strtolower(ltrim($className, '\\'));
return \in_array(strtolower(ltrim($className, '\\')), self::DENIED_LC, true);
}

private static function displayName(string $className): string
Expand Down
21 changes: 21 additions & 0 deletions test/compliance/cases/stdlib/curl_handle_serialize_disallowed.phpt
Original file line number Diff line number Diff line change
@@ -0,0 +1,21 @@
--TEST--
stdlib CurlHandle serialize()/unserialize() reject (issue #23074, ext/curl/curl.stub.php)
--FILE--
<?php
$ch = curl_init();
try {
serialize($ch);
echo "serialize:no-throw\n";
} catch (Throwable $e) {
echo get_class($e), ':', $e->getMessage(), "\n";
}

try {
unserialize('O:10:"CurlHandle":0:{}');
echo "unserialize:no-throw\n";
} catch (Throwable $e) {
echo get_class($e), ':', $e->getMessage(), "\n";
}
--EXPECT--
Exception:Serialization of 'CurlHandle' is not allowed
Exception:Unserialization of 'CurlHandle' is not allowed
Original file line number Diff line number Diff line change
@@ -0,0 +1,20 @@
--TEST--
stdlib CurlMultiHandle/CurlShareHandle serialize() reject (issue #23074 sibling)
--FILE--
<?php
try {
serialize(curl_multi_init());
echo "multi:no-throw\n";
} catch (Throwable $e) {
echo get_class($e), ':', $e->getMessage(), "\n";
}

try {
serialize(curl_share_init());
echo "share:no-throw\n";
} catch (Throwable $e) {
echo get_class($e), ':', $e->getMessage(), "\n";
}
--EXPECT--
Exception:Serialization of 'CurlMultiHandle' is not allowed
Exception:Serialization of 'CurlShareHandle' is not allowed
17 changes: 17 additions & 0 deletions test/repro/issue_23074_curlhandle_serialize_deny.php
Original file line number Diff line number Diff line change
@@ -0,0 +1,17 @@
<?php

declare(strict_types=1);

$ch = curl_init();
try {
echo serialize($ch), "\n";
} catch (Throwable $e) {
echo get_class($e), ':', $e->getMessage(), "\n";
}

try {
unserialize('O:10:"CurlHandle":0:{}');
echo "unserialize:no-throw\n";
} catch (Throwable $e) {
echo get_class($e), ':', $e->getMessage(), "\n";
}