Stdlib: deny CurlHandle/Multi/Share serialize like Zend (#23074) - #23079
Merged
Merged
Conversation
Extend CurlFileSerializeDeny (post-#23064) so curl handle objects throw the same Exception as php-src @not-serializable stubs on serialize/unserialize. Co-authored-by: Cursor <cursoragent@cursor.com>
This was referenced Jul 25, 2026
Bootstrap: unblock gen-0 spine refresh — docblock, ghost require, exclusive launcher (#22642)
#22717
Closed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
CurlFileSerializeDeny(from Regression: CURLFile serialize() allowed — Zend Exception "not allowed" (ext/curl/curl_file.c) #23064) soCurlHandle,CurlMultiHandle,CurlShareHandle, and persistent share handles throw Zend-identicalException: Serialization of '…' is not allowed/ unserialize deny.ext/curl/curl.stub.php@not-serializable; shared path remainsVmSerialize→SerializeJitHelper(PHP-in-PHP, no newruntime/C).curl_handle_serialize_disallowed.phpt+curl_multi_share_serialize_disallowed.phpt(split so multi/share are not after a CurlHandle throw — guest Exception message retention quirk).Closes #23074
Test plan
php bin/vm.php test/repro/issue_23074_curlhandle_serialize_deny.phpphp bin/jit.php test/repro/issue_23074_curlhandle_serialize_deny.php./script/phpunit.sh --filter 'curl_handle_serialize_disallowed|curl_multi_share_serialize_disallowed'(VM+JIT, 4 tests)php script/bootstrap-inventory.php --check→ OK 6531/6531curl_init()not on JIT/AOT (Stdlib: curl_share_init()/curl_share_setopt()/curl_share_close() — shared cURL handle pool missing (ext/curl) #6322); baretry/throw ExceptionAOT currently fails withCurrent basic block has no parent function;unserialize()AOT reports result type unsupported. Deny lives in sharedVmSerializealready exercised by JIT.Verification transcript
Made with Cursor