Repository navigation
Stdlib: pgsql legacy PHP_FALIAS aliases (#22219) - #22259
Merged
Merged
Conversation
Wire Zend-era aliases (pg_exec, pg_numrows, pg_loopen, …) to the existing modern handlers so function_exists and calls match php-src stub aliases. Co-authored-by: Cursor <cursoragent@cursor.com>
This was referenced Jul 22, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
ext/pgsqllegacy aliases (pg_exec,pg_numrows,pg_cmdtuples,pg_loopen, …,pg_result→pg_fetch_result) as second registrations of the existing Internal handlers (PHP_FALIAS/ stub@alias).$namector on alias targets; no duplicated execute bodies; no newruntime/*.c.pgsql_legacy_aliases.phpt+test/repro/issue_22219_pgsql_legacy_aliases.php.php-src:
ext/pgsql/pgsql.stub.php,ext/pgsql/pgsql.cPHP impl:
ext/pgsql/Module.php+ ctor pass-through on modern handlersCloses #22219
Test plan
php bin/vm.php test/repro/issue_22219_pgsql_legacy_aliases.php→ allY/ exit 0php bin/compile.php -l test/repro/issue_22219_pgsql_legacy_aliases.php→ exit 0vendor/bin/phpunit --filter pgsql_legacy_aliases→ OK (2 tests, VM+JIT)php script/bootstrap-inventory.php --check→ OK 6392/6392./phpc buildstandalone AOT currently red on master even forexamples/000-HelloWorld(LLVM module verify); lint path is green for this repro.Pre-claim gates
release-readiness --json→user_release_ready: yesMade with Cursor