Repository navigation
php-in-php: StringStrcoll NestedJIT → JitVmHelperLink::ensureCompiled (#22256) - #22257
Merged
Merged
Conversation
…#22256) Route StrcollJitHelper compile through the shared helper-link path (env clear, insert restore, helper-runtime cache) instead of a hand-rolled NestedJitCompileScope block. Co-authored-by: Cursor <cursoragent@cursor.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
StringStrcollNestedJIT helper compile throughJitVmHelperLink::ensureCompiled(peer php-in-php: CopyRuntime NestedJIT → JitVmHelperLink::ensureCompiled (#1492) #22231 CopyRuntime / php-in-php: SysGetTempDirRuntime NestedJIT → JitVmHelperLink::ensureCompiled (#1492) #22187 SysGetTempDirRuntime).NestedJitCompileScope::run+parseAndCompile+new JIT()(−21 lines in ensure path).StrcollRuntimeShrinkTestto guard the shared link path.Closes #22256
Net shrink
lib/JIT/Builtin/StringStrcoll.php: 157 → 137 lines; hand-rolled NestedJIT block replaced byJitVmHelperLink::ensureCompiled.Test plan
./script/docker-exec.sh -- bash -lc 'source script/php-env.sh && vendor/bin/phpunit test/unit/StrcollRuntimeShrinkTest.php'→ OK (6 tests, 18 assertions)./script/docker-exec.sh -- bash -lc 'make bootstrap-selfhost-vm-driver-execute-probe'→ OKuser_release_ready: yes, helloworld OKphp-src reference
PHP_FUNCTION(strcoll)(semantics unchanged; compile-path only)Made with Cursor