Skip to content

Stdlib: IntlCalendar getType/add/roll/clear/equals/DateTime bridges (#20756) - #20817

Merged
PurHur merged 1 commit into
masterfrom
fix/20756-intlcalendar-methods
Jul 19, 2026
Merged

PurHur merged 1 commit into
masterfrom
fix/20756-intlcalendar-methods

Conversation

@PurHur

@PurHur PurHur commented Jul 19, 2026

Copy link
Copy Markdown
Owner

Summary

Closes #20756

Test plan

  • PHP_COMPILER_PROFILE=8.4 php bin/vm.php test/repro/issue_intlcalendar_methods.php
    type=gregorian
    getNow_float=1
    after_add_day=2024-1-16
    after_roll_month=2024-2-15
    toDateTime=2024-01-15 12:00:00 UTC
    fromDateTime=2024-6-1
    equals=1
    isset_hour_after_clear=0
    after_clear_all_year=1970
    methods=1111111
    
  • vendor/bin/phpunit --filter intlcalendar_methods → OK (2 tests, VM+JIT)
  • vendor/bin/phpunit --filter intlcalendar_timezone → OK (2 tests)
  • php script/bootstrap-inventory.php --check → OK 5844/5844
  • ./script/check-generated-docs.sh → in sync

php-src-strict; no php-compiler-strict shortcut.

Made with Cursor

…20756)

Extend the Gregorian IntlCalendar subset with field arithmetic, clear/isSet,
getNow, and toDateTime/fromDateTime so calendar OOP matches php-src on the
minimal cases frameworks need after #6151.

Co-authored-by: Cursor <cursoragent@cursor.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Stdlib: IntlCalendar::getType()/add()/roll()/toDateTime() missing after #6151 (ext/intl/calendar)

1 participant