Repository navigation
php-in-php: NestedJIT bool extract + array_is_list packed check for HashAlgos AOT (#20652) - #20726
Merged
Merged
Conversation
…ashAlgos AOT (#20652) Route ArrayIsListJitHelper through HashTable::isPackedList (NestedJIT LLVM) instead of VmArray::isList foreach, and extract bool helper results without readLong. Update hash_hmac_algos AOT fixture to use user-script foreach (in_array NestedJIT iterate still broken under AOT). Co-authored-by: Cursor <cursoragent@cursor.com>
…w-up (#20652) Co-authored-by: Cursor <cursoragent@cursor.com>
4 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
hash_hmac_algosfixture green.ArrayIsListJitHelperusesHashTable::isPackedList()(NestedJIT →HashTableIsPackedListLLVM) instead ofVmArray::isList()foreach (always-false under user-script AOT).JitNestedHelperCoerce::extractBoolFromHelperResult— bool helper returns must not go throughreadLong(bootstrap-aot-link: VALUE-box concat + ordered float compare lowering #8555).foreachfor sha256/sha512 membership (in_arrayNestedJITiterateforeach still broken under AOT).php-src reference
php_array_is_list/in_arrayhash_hmac_algosC / runtime shrink
Verification
Closes #20652
Test plan
hash_hmac_algosfixturebootstrap-selfhost-vm-driver-execute-probeMade with Cursor