Skip to content

php-in-php: drop HashAlgos/HmacAlgos thin kernel fork — always JitVmHelperLink (#20652) - #20714

Merged
PurHur merged 2 commits into
masterfrom
agent/runtime-php-hash-algos-always-helper-20652
Jul 18, 2026
Merged

PurHur merged 2 commits into
masterfrom
agent/runtime-php-hash-algos-always-helper-20652

Conversation

@PurHur

@PurHur PurHur commented Jul 18, 2026 •

Copy link
Copy Markdown
Owner

Summary

php-src reference

  • ext/hash/hash.c — PHP_FUNCTION(hash_algos) / PHP_FUNCTION(hash_hmac_algos)

Verification (maintainer, local Docker)

./script/docker-exec.sh -- bash -lc 'source script/php-env.sh
vendor/bin/phpunit test/unit/StringHashAlgosRuntimeShrinkTest.php
# OK (2 tests, 19 assertions)
vendor/bin/phpunit test/unit/StringHashHmacAlgosRuntimeShrinkTest.php
# OK (2 tests, 17 assertions)
php bin/jit.php /tmp/h.php   # 60 44
php bin/vm.php /tmp/h.php    # 60 44
make bootstrap-selfhost-vm-driver-execute-probe
# OK
php script/bootstrap-inventory.php --check
# OK 5800/5800
php script/check-selfhost-spine-count-sync.php
# OK 5800/5800
'

AOT packing (still red — pre-existing)

With PHP_COMPILER_HELPER_RUNTIME_O=0, AOT hash_hmac_algos still prints assoc / no_sha256 while count===44 (same shape on master thin-kernel path before this PR). JIT/VM are green. Follow-up keeps #20652 open until AOT fixture is green.

Related: #20652 (bridge shrink landed here; AOT packing remains).

Test plan

PurHur and others added 2 commits July 18, 2026 22:58
…elperLink (#20652)

Route thin standalone AOT through HashAlgosJitHelper + phpc_hash_*_algos_kernel
NestedJIT leaves (Rename/Fpow shape). Bridge return type is array → __hashtable__*
to avoid HashTable class TypeError. Removes isThinStandaloneAotMain registry ABI
from StringHashAlgos/StringHashHmacAlgos.

Co-authored-by: Cursor <cursoragent@cursor.com>
Co-authored-by: Cursor <cursoragent@cursor.com>
@PurHur
PurHur force-pushed the agent/runtime-php-hash-algos-always-helper-20652 branch from d0c6e4b to 57e45c1 Compare July 18, 2026 23:02
@PurHur
PurHur merged commit 3ee77ea into master Jul 18, 2026
1 check failed
@PurHur
PurHur deleted the agent/runtime-php-hash-algos-always-helper-20652 branch July 18, 2026 23:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant