Repository navigation
php-in-php: drop HashAlgos/HmacAlgos thin kernel fork — always JitVmHelperLink (#20652) - #20714
Merged
Merged
Conversation
…elperLink (#20652) Route thin standalone AOT through HashAlgosJitHelper + phpc_hash_*_algos_kernel NestedJIT leaves (Rename/Fpow shape). Bridge return type is array → __hashtable__* to avoid HashTable class TypeError. Removes isThinStandaloneAotMain registry ABI from StringHashAlgos/StringHashHmacAlgos. Co-authored-by: Cursor <cursoragent@cursor.com>
Co-authored-by: Cursor <cursoragent@cursor.com>
PurHur
force-pushed
the
agent/runtime-php-hash-algos-always-helper-20652
branch
from
July 18, 2026 23:02
d0c6e4b to
57e45c1
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
isThinStandaloneAotMain→JitHashAlgosKernelthin registry ABI fromStringHashAlgos/StringHashHmacAlgos; alwaysJitVmHelperLink::ensureBridge→HashAlgosJitHelper(Rename php-in-php: drop isThinStandaloneAotMain libc fork from StringRename — always JitVmHelperLink + RenameJitHelper (re-#20028) #20603 / Fpow php-in-php: NestedJIT helper return ABI for double + __hashtable__* + string|false value-box (unblocks thin AOT always-helper) #20664 shape).phpc_hash_algos_kernel/phpc_hash_hmac_algos_kernelNestedJIT leaves (JitHashAlgosKernel::invoke*); helper returnsarray(notHashTable) so NestedJIT uses__hashtable__*instead of object TypeError.ext/hash/.php-src reference
PHP_FUNCTION(hash_algos)/PHP_FUNCTION(hash_hmac_algos)Verification (maintainer, local Docker)
AOT packing (still red — pre-existing)
With
PHP_COMPILER_HELPER_RUNTIME_O=0, AOThash_hmac_algosstill printsassoc/no_sha256whilecount===44(same shape on master thin-kernel path before this PR). JIT/VM are green. Follow-up keeps #20652 open until AOT fixture is green.Related: #20652 (bridge shrink landed here; AOT packing remains).
Test plan
hash_algos/hash_hmac_algoscounts greenbootstrap-selfhost-vm-driver-execute-probegreenhash_hmac_algos.phptgreen (blocked — packing; tracked on php-in-php: drop isThinStandaloneAotMain kernel from StringHashAlgos/HmacAlgos — always JitVmHelperLink + HashAlgosJitHelper (re-#20050) #20652)