Repository navigation
Stdlib: Dom\HTMLDocument/XMLDocument Document API (#20556) - #20582
Merged
Merged
Conversation
Share DOMDocument create/query/import/adopt/save handlers with living Dom\ Document classes, add getElementsByClassName, and fix saveXml doctype serialization for HTML documents with DocumentType children. Co-authored-by: Cursor <cursoragent@cursor.com>
PurHur
force-pushed
the
agent/issue-20556-dom-document-api
branch
from
July 18, 2026 15:13
5a57dc1 to
f644def
Compare
PurHur
added a commit
that referenced
this pull request
Jul 18, 2026
Unblocks spine sync for the pgsql PHP 8.4 helpers PR (#7083).
PurHur
added a commit
that referenced
this pull request
Jul 18, 2026
* Stdlib: ext/pgsql PHP 8.4 helpers (pg_jit/copy/memory/…) (#7083) Register pg_change_password, pg_jit, pg_put_copy_data/end, pg_result_memory_size, pg_set_chunked_rows_size, and pg_socket_poll when libpq FFI is available. Real PQresultMemorySize / COPY / SHOW jit paths; chunked-rows and socket-poll idle-return on older libpq without those APIs. Co-authored-by: Cursor <cursoragent@cursor.com> * Bootstrap: spine-cover Dom GetElementsByClassName after #20582 Unblocks spine sync for the pgsql PHP 8.4 helpers PR (#7083). --------- Co-authored-by: PurHur <PurHur@users.noreply.github.com> Co-authored-by: Cursor <cursoragent@cursor.com>
This was referenced Jul 18, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Dom\HTMLDocument/Dom\XMLDocumentDocument methods (createElement*,getElementsByTagName*,getElementsByClassName,importNode/adoptNode,saveXml/saveXmlFile/saveHtmlFile, ParentNodeappend/prepend/replaceChildren) by sharing legacyDOMDocumenthandlers and accepting living documents inVmDom::requireReceiver.getElementsByClassNamelive NodeList collection; fixsaveXMLDocumentType child serialization (HTML docs with doctype).ext/dom/php_dom.stub.php(Dom\Document/HTMLDocument/XMLDocument). PHP-in-PHP only — no newruntime/*.c.Closes #20556
Test plan
PHP_COMPILER_PROFILE=8.4 php bin/vm.php test/repro/issue_20556_dom_document_api.php— all methods yes; create/query/import/save/adopt okvendor/bin/phpunit test/compliance/VMTest.php --filter dom_living_document_api— OKPHP_COMPILER_PROFILE=8.4 vendor/bin/phpunit test/compliance/VMTest.php --filter dom_html_document— OK (no regression)php script/bootstrap-inventory.php --check— OK 5681/5681MathBaseConvertRuntime::constFloat/ cold helper emit; issue done-when is VM php-src-strictTrust snapshot
Made with Cursor