Stdlib: SQLite3 open/lastError*/version/createCollation/backup (#20565) - #20577
Merged
Merged
Conversation
Register remaining stub methods via PHP-in-PHP + libsqlite3 FFI so apps can reopen after close, read error state, report library version, register collations, and backup databases (php-src ext/sqlite3/sqlite3.c). Co-authored-by: Cursor <cursoragent@cursor.com>
This was referenced Jul 18, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
SQLite3::open,lastErrorCode/lastErrorMsg, staticversion,createCollation, andbackupin PHP-in-PHP (ext/sqlite3/) with libsqlite3 FFI — matching php-srcext/sqlite3/sqlite3.c.SQLite3::totalChanges()(issue-doc drift); left unimplemented.createCollationregisters/stores the callable (parity withcreateFunction); full COLLATE FFI callback remains follow-up.runtime/*.c.Closes #20565
Test plan
PHP_COMPILER_PROFILE=8.4 php bin/vm.php test/repro/sqlite3_open_error_version_backup.php→okPHP_COMPILER_PROFILE=8.4 ./phpc build -o /tmp/sq_adv2 test/repro/sqlite3_20565_aot_advertise.php && /tmp/sq_adv2→ all methods=Y/ok(AOT advertisement; instance execution under AOT is a pre-existing SQLite3 gap — same asexec)vendor/bin/phpunit --filter sqlite3_open_error_version_backup→ OK (2 tests)php script/bootstrap-inventory.php --check→ OK 5685/5685php-src-strict · Pillar 4 stdlib
Made with Cursor