php-in-php: delete JitFileGetContentsKernel — always JitVmHelperLink + FileGetContentsJitHelper PHP (#19339) - #19956
Merged
Conversation
…+ FileGetContentsJitHelper PHP (#19339) Remove the ~185 LOC libc open/read LLVM kernel from ext/standard/JitFileGetContentsKernel.php. StringFileGetContents now always routes through FileGetContentsJitHelper → VmFs::fileGetContents() via JitVmHelperLink, matching the Unlink pattern (#19186). - Delete ext/standard/JitFileGetContentsKernel.php (185 lines removed) - Remove UserScriptAotDeferNestedJit defer path from StringFileGetContents - Remove implementUserScriptKernel() method entirely - Remove kernel from spine require list; add mb_strstr.php (sync fix for #19942) - Update FileGetContentsRuntimeShrinkTest to assert kernel deletion - Regenerate bootstrap-inventory.md Verification: vendor/bin/phpunit test/unit/FileGetContentsRuntimeShrinkTest.php — OK (4 tests, 16 assertions) make bootstrap-selfhost-vm-driver-execute-probe — OK php script/bootstrap-inventory.php --check — OK 5330/5330 php script/check-selfhost-spine-coverage-sync.php — OK Closes #19339 Co-authored-by: Cursor <cursoragent@cursor.com>
6 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
ext/standard/JitFileGetContentsKernel.php(185 LOC libc open/read LLVM kernel)UserScriptAotDeferNestedJitdefer path fromStringFileGetContents— user-script AOT now routes through the sameJitVmHelperLink+FileGetContentsJitHelper→VmFs::fileGetContents()PHP bridge as embed modefile_get_contentsis now fully PHP-in-PHPChanges
ext/standard/JitFileGetContentsKernel.phplib/JIT/Builtin/StringFileGetContents.phpimplementUserScriptKernel(),UserScriptAotDeferNestedJitimport,LibcExternimport,KERNEL_ENTRYconst;implement()always callsimplementPhpBridge()test/unit/FileGetContentsRuntimeShrinkTest.phpUserScriptAotDeferNestedJitin bridgetest/selfhost/compiler_lib_spine_smoke/main.phpmb_strstr.php(spine sync fix for #19942)docs/bootstrap-inventory.mdphp-src reference
ext/standard/file.c/streamsfuncs.c—PHP_FUNCTION(file_get_contents)/php_stream_copy_to_memVerification
Closes #19339
Refs #1492, #15309, #19186, #19279
Made with Cursor