php-in-php: delete StringFileGetContentsLibc — user-script AOT via JitVmHelperLink + FileGetContentsJitHelper PHP (#1492)

[PurHur]

Category

php-in-php · runtime-shrink (#1492, same pattern as #19186 unlink / #19215 rename)

Problem

lib/JIT/Builtin/StringFileGetContents.php still routes UserScriptAotDeferNestedJit::shouldDefer() through StringFileGetContentsLibc (~211 LOC hand-written libc open/read LLVM). Embed/full JIT already uses FileGetContentsJitHelper → VmFs::fileGetContents(). FileGetContentsJitHelper is already present in prelinked/helper-runtime/.../units (same cache Unlink used successfully after #19186).

php-src reference

• php/php-src ext/standard/file.c / streamsfuncs.c — PHP_FUNCTION(file_get_contents) / php_stream_copy_to_mem

PHP implementation target

• lib/JIT/Builtin/StringFileGetContents.php — always JitVmHelperLink::ensureBridge (drop defer → Libc early-return)
• Delete lib/JIT/Builtin/StringFileGetContentsLibc.php
• Update test/unit/FileGetContentsRuntimeShrinkTest.php + spine require list
• Keep SSOT: ext/standard/FileGetContentsJitHelper.php → VmFs::fileGetContents()

Repro

./script/docker-exec.sh -- bash -lc 'source script/php-env.sh
vendor/bin/phpunit test/unit/FileGetContentsRuntimeShrinkTest.php
vendor/bin/phpunit test/aot/AotTest.php --filter "data set \\\"file_get_contents\\\""
tmpdir=$(mktemp -d)
echo hi > "$tmpdir/x"
php bin/compile.php -o "$tmpdir/fgc" -r "echo file_get_contents(\"$tmpdir/x\");"
"$tmpdir/fgc"
'

Done when

• StringFileGetContentsLibc.php deleted
• UserScriptAotDeferNestedJit removed from StringFileGetContents bridge path
• AOT file_get_contents fixture green
• make bootstrap-selfhost-vm-driver-execute-probe green
• PR body cites lines removed

Refs #1492, #15309, #17036, #19186

[PurHur]

claim: PHP Runtime → PHP — starting this run.

Pillar 1 gates (before claim):

Gate	Result
bootstrap-inventory --check	OK 4961/4961 (via release-readiness)
./script/release-readiness.sh --json	user_release_ready: yes
north-star5-verify --fast	ok
bootstrap-selfhost-vm-driver-execute-probe	ok

Plan: mirror #19186 (StringUnlink) — always JitVmHelperLink::ensureBridge → FileGetContentsJitHelper; delete StringFileGetContentsLibc.php (~211 LOC).

[PurHur]

Merged via #19289

What shipped: deleted lib/JIT/Builtin/StringFileGetContentsLibc.php (211 LOC); user-script AOT defer now uses ext/standard/JitFileGetContentsKernel.php (rename-kernel pattern from #19215). Embed/self-host keeps FileGetContentsJitHelper PHP bridge.

Blocker note: full JitVmHelperLink → FileGetContentsJitHelper on defer still fails under #16075 (same class as #19165 hash). Kernel path required for AOT green.

Verification:

• FileGetContentsRuntimeShrinkTest OK (4 tests)
• AotTest file_get_contents + file_get_contents_offset OK (2 tests)
• inventory OK 4961/4961 · spine sync OK · bootstrap-selfhost-vm-driver-execute-probe OK